All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: christoffer.dall@linaro.org, xen-devel@lists.xenproject.org,
	tim@xen.org, parth.dixit@linaro.org,
	stefano.stabellini@citrix.com
Subject: Re: [PATCH v2 1/3] xen/arm: vgic: Rename nr_lines into nr_spis
Date: Tue, 20 Jan 2015 13:41:04 +0000	[thread overview]
Message-ID: <54BE5AF0.6020307@linaro.org> (raw)
In-Reply-To: <1421686850.10440.164.camel@citrix.com>

Hi Ian,

On 19/01/15 17:00, Ian Campbell wrote:
> On Thu, 2015-01-15 at 20:23 +0000, Julien Grall wrote:
>> The field nr_lines in the arch_domain vgic structure contains the number of
>> SPIs for the emulated GIC. Using the nr_lines make confusion with the GIC
>> code, where it means the number of IRQs. This can lead to coding error.
>>
>> Also introduce vgic_num_irqs to get the number of IRQ handled by the emulated
>> GIC.
>>
>> Finally drop the initialization of nr_spis in both gicv2v_init and gicv3_init
>> as it's already initialized in vgic common code.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> 
> Acked + applied.
> 
> 

Thanks, I will rebase my series "[PATCH 00/10] xen/arm: Bug fixes for
the vGIC" [1] on top of it. Though I could wait a bit for your review on it.

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-01-20 13:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 20:23 [PATCH v2 0/3] Find automatically a PPI for the DOM0 event channel IRQ Julien Grall
2015-01-15 20:23 ` [PATCH v2 1/3] xen/arm: vgic: Rename nr_lines into nr_spis Julien Grall
2015-01-19 17:00   ` Ian Campbell
2015-01-20 13:41     ` Julien Grall [this message]
2015-01-15 20:23 ` [PATCH v2 2/3] xen/arm: vgic: Keep track of vIRQ used by a domain Julien Grall
2015-01-19 15:55   ` Ian Campbell
2015-01-19 16:14     ` Julien Grall
2015-01-19 16:28       ` Ian Campbell
2015-01-15 20:23 ` [PATCH v2 3/3] xen/arm: Find automatically a PPI for the DOM0 event channel interrupt Julien Grall
2015-01-19 16:04   ` Ian Campbell
2015-01-19 16:19     ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BE5AF0.6020307@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Campbell@citrix.com \
    --cc=christoffer.dall@linaro.org \
    --cc=parth.dixit@linaro.org \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.