From: Bo Shen <voice.shen@atmel.com>
To: Peter Rosin <peda@lysator.liu.se>
Cc: Mark Brown <broonie@kernel.org>,
nicolas.ferre@atmel.com, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments
Date: Tue, 20 Jan 2015 09:00:16 +0800 [thread overview]
Message-ID: <54BDA8A0.1050604@atmel.com> (raw)
In-Reply-To: <54BD0CA5.4070207@lysator.liu.se>
Hi Peter,
On 01/19/2015 09:54 PM, Peter Rosin wrote:
>> As the clock can be get from TK/RK pin, so remove the comments.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/soc/atmel/atmel_ssc_dai.c | 4 ----
>> 1 file changed, 4 deletions(-)
>> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
>> index e691aab..198661b 100644
>> --- a/sound/soc/atmel/atmel_ssc_dai.c
>> +++ b/sound/soc/atmel/atmel_ssc_dai.c
>> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM:
>> /*
>> * I2S format, CODEC supplies BCLK and LRC clocks.
>> - *
>> - * The SSC transmit clock is obtained from the BCLK signal on
>> - * on the TK line, and the SSC receive clock is
>> - * generated from the transmit clock.
>> */
>> rcmr = SSC_BF(RCMR_PERIOD, 0)
>> | SSC_BF(RCMR_STTDLY, START_DELAY)
>> --
>> 2.3.0.rc0
>
> Hi!
>
> You should probably remove that comment from the case with
> SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well...
Thanks, I will remove it in next version.
> Cheers,
> Peter
>
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Peter Rosin <peda@lysator.liu.se>
Cc: Mark Brown <broonie@kernel.org>,
nicolas.ferre@atmel.com, alsa-devel@alsa-project.org,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments
Date: Tue, 20 Jan 2015 01:00:16 +0000 [thread overview]
Message-ID: <54BDA8A0.1050604@atmel.com> (raw)
In-Reply-To: <54BD0CA5.4070207@lysator.liu.se>
Hi Peter,
On 01/19/2015 09:54 PM, Peter Rosin wrote:
>> As the clock can be get from TK/RK pin, so remove the comments.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/soc/atmel/atmel_ssc_dai.c | 4 ----
>> 1 file changed, 4 deletions(-)
>> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
>> index e691aab..198661b 100644
>> --- a/sound/soc/atmel/atmel_ssc_dai.c
>> +++ b/sound/soc/atmel/atmel_ssc_dai.c
>> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM:
>> /*
>> * I2S format, CODEC supplies BCLK and LRC clocks.
>> - *
>> - * The SSC transmit clock is obtained from the BCLK signal on
>> - * on the TK line, and the SSC receive clock is
>> - * generated from the transmit clock.
>> */
>> rcmr = SSC_BF(RCMR_PERIOD, 0)
>> | SSC_BF(RCMR_STTDLY, START_DELAY)
>> --
>> 2.3.0.rc0
>
> Hi!
>
> You should probably remove that comment from the case with
> SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well...
Thanks, I will remove it in next version.
> Cheers,
> Peter
>
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments
Date: Tue, 20 Jan 2015 09:00:16 +0800 [thread overview]
Message-ID: <54BDA8A0.1050604@atmel.com> (raw)
In-Reply-To: <54BD0CA5.4070207@lysator.liu.se>
Hi Peter,
On 01/19/2015 09:54 PM, Peter Rosin wrote:
>> As the clock can be get from TK/RK pin, so remove the comments.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/soc/atmel/atmel_ssc_dai.c | 4 ----
>> 1 file changed, 4 deletions(-)
>> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
>> index e691aab..198661b 100644
>> --- a/sound/soc/atmel/atmel_ssc_dai.c
>> +++ b/sound/soc/atmel/atmel_ssc_dai.c
>> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM:
>> /*
>> * I2S format, CODEC supplies BCLK and LRC clocks.
>> - *
>> - * The SSC transmit clock is obtained from the BCLK signal on
>> - * on the TK line, and the SSC receive clock is
>> - * generated from the transmit clock.
>> */
>> rcmr = SSC_BF(RCMR_PERIOD, 0)
>> | SSC_BF(RCMR_STTDLY, START_DELAY)
>> --
>> 2.3.0.rc0
>
> Hi!
>
> You should probably remove that comment from the case with
> SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well...
Thanks, I will remove it in next version.
> Cheers,
> Peter
>
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Peter Rosin <peda@lysator.liu.se>
Cc: Mark Brown <broonie@kernel.org>, <nicolas.ferre@atmel.com>,
<alsa-devel@alsa-project.org>, <linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments
Date: Tue, 20 Jan 2015 09:00:16 +0800 [thread overview]
Message-ID: <54BDA8A0.1050604@atmel.com> (raw)
In-Reply-To: <54BD0CA5.4070207@lysator.liu.se>
Hi Peter,
On 01/19/2015 09:54 PM, Peter Rosin wrote:
>> As the clock can be get from TK/RK pin, so remove the comments.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/soc/atmel/atmel_ssc_dai.c | 4 ----
>> 1 file changed, 4 deletions(-)
>> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
>> index e691aab..198661b 100644
>> --- a/sound/soc/atmel/atmel_ssc_dai.c
>> +++ b/sound/soc/atmel/atmel_ssc_dai.c
>> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM:
>> /*
>> * I2S format, CODEC supplies BCLK and LRC clocks.
>> - *
>> - * The SSC transmit clock is obtained from the BCLK signal on
>> - * on the TK line, and the SSC receive clock is
>> - * generated from the transmit clock.
>> */
>> rcmr = SSC_BF(RCMR_PERIOD, 0)
>> | SSC_BF(RCMR_STTDLY, START_DELAY)
>> --
>> 2.3.0.rc0
>
> Hi!
>
> You should probably remove that comment from the case with
> SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well...
Thanks, I will remove it in next version.
> Cheers,
> Peter
>
Best Regards,
Bo Shen
next prev parent reply other threads:[~2015-01-20 1:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 7:19 [PATCH 1/2] ASoC: atmel_ssc_dai: fix start event for I2S mode Bo Shen
2015-01-16 7:19 ` Bo Shen
2015-01-16 7:19 ` Bo Shen
2015-01-16 7:19 ` Bo Shen
2015-01-16 7:19 ` [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments Bo Shen
2015-01-16 7:19 ` Bo Shen
2015-01-16 7:19 ` Bo Shen
2015-01-16 7:19 ` Bo Shen
2015-01-19 13:54 ` Peter Rosin
2015-01-19 13:54 ` Peter Rosin
2015-01-19 13:54 ` Peter Rosin
2015-01-20 1:00 ` Bo Shen [this message]
2015-01-20 1:00 ` Bo Shen
2015-01-20 1:00 ` Bo Shen
2015-01-20 1:00 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BDA8A0.1050604@atmel.com \
--to=voice.shen@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=peda@lysator.liu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.