Re: [PATCH] MIPS: Display CPU byteorder in /proc/cpuinfo

[Joshua Kinard <kumba@gentoo.org>]

On 01/21/2015 05:22, Markos Chandras wrote:
> On 01/21/2015 02:54 AM, Joshua Kinard wrote:
>> On 01/20/2015 21:45, Joshua Kinard wrote:
>>> On 01/20/2015 18:05, David Daney wrote:
>>>> On 01/19/2015 01:02 AM, Joshua Kinard wrote:
>>>>> From: Joshua Kinard <kumba@gentoo.org>
>>>>>
>>>>> This is a small patch to display the CPU byteorder that the kernel was compiled
>>>>> with in /proc/cpuinfo.
>>>>
>>>> What would use this?  Or in other words, why is this needed?
>>>
>>> It was a patch I started including years ago in Gentoo's mips-sources, and just
>>> never thought much about.  I know it was submitted several times in the past,
>>> but I can't recall what, if any objection was ever made.  No harm in sending it
>>> in again...
>>
>> Clarification, submitted several times in the past by others.  I think I sent
>> it in once prior, but never got review or feedback.
>>
> I believe this patch is mostly useful for cores that can boot in both LE
> and BE so being able to tell the byteorder from cpuinfo can be helpful
> at times. Having readelf and other tools in your userland may not always
> be the case, but you surely have "cat" :)
> 
> So that patch looks good to me but i think the #ifdefs can be avoided.
> Can we use
> 
> if (config_enabled(CONFIG_CPU_BIG_ENDIAN) {
> } else {
> }
> 
> stuff instead?

Sure, I just tested on the Octane, and it works fine.  I'll send a v2 shortly.

--J