From: Paolo Bonzini <pbonzini@redhat.com>
To: Chris J Arges <chris.j.arges@canonical.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386
Date: Tue, 27 Jan 2015 21:27:50 +0100 [thread overview]
Message-ID: <54C7F4C6.5000407@redhat.com> (raw)
In-Reply-To: <1422390185-27896-1-git-send-email-chris.j.arges@canonical.com>
On 27/01/2015 21:23, Chris J Arges wrote:
> There is a failure to build on 32-bit hosts:
> x86/hypercall.c: In function ‘test_edge’:
> x86/hypercall.c:42:2: error: ‘test_rip’ undeclared (first use in this function)
> test_rip = 0;
> ^
>
> This patch fixes this issue.
>
> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
> ---
> x86/hypercall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/hypercall.c b/x86/hypercall.c
> index 1548421..3ac5ff9 100644
> --- a/x86/hypercall.c
> +++ b/x86/hypercall.c
> @@ -24,8 +24,8 @@ static inline long kvm_hypercall0_amd(unsigned int nr)
> }
>
>
> -#ifdef __x86_64__
> volatile unsigned long test_rip;
> +#ifdef __x86_64__
> extern void gp_tss(void);
> asm ("gp_tss: \n\t"
> "add $8, %rsp\n\t" // discard error code
>
Thanks, applied.
Paolo
prev parent reply other threads:[~2015-01-27 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 20:23 [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386 Chris J Arges
2015-01-27 20:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C7F4C6.5000407@redhat.com \
--to=pbonzini@redhat.com \
--cc=chris.j.arges@canonical.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.