* [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386
@ 2015-01-27 20:23 Chris J Arges
2015-01-27 20:27 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Chris J Arges @ 2015-01-27 20:23 UTC (permalink / raw)
To: kvm; +Cc: pbonzini
There is a failure to build on 32-bit hosts:
x86/hypercall.c: In function ‘test_edge’:
x86/hypercall.c:42:2: error: ‘test_rip’ undeclared (first use in this function)
test_rip = 0;
^
This patch fixes this issue.
Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
---
x86/hypercall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/x86/hypercall.c b/x86/hypercall.c
index 1548421..3ac5ff9 100644
--- a/x86/hypercall.c
+++ b/x86/hypercall.c
@@ -24,8 +24,8 @@ static inline long kvm_hypercall0_amd(unsigned int nr)
}
-#ifdef __x86_64__
volatile unsigned long test_rip;
+#ifdef __x86_64__
extern void gp_tss(void);
asm ("gp_tss: \n\t"
"add $8, %rsp\n\t" // discard error code
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386
2015-01-27 20:23 [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386 Chris J Arges
@ 2015-01-27 20:27 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-01-27 20:27 UTC (permalink / raw)
To: Chris J Arges, kvm
On 27/01/2015 21:23, Chris J Arges wrote:
> There is a failure to build on 32-bit hosts:
> x86/hypercall.c: In function ‘test_edge’:
> x86/hypercall.c:42:2: error: ‘test_rip’ undeclared (first use in this function)
> test_rip = 0;
> ^
>
> This patch fixes this issue.
>
> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
> ---
> x86/hypercall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/hypercall.c b/x86/hypercall.c
> index 1548421..3ac5ff9 100644
> --- a/x86/hypercall.c
> +++ b/x86/hypercall.c
> @@ -24,8 +24,8 @@ static inline long kvm_hypercall0_amd(unsigned int nr)
> }
>
>
> -#ifdef __x86_64__
> volatile unsigned long test_rip;
> +#ifdef __x86_64__
> extern void gp_tss(void);
> asm ("gp_tss: \n\t"
> "add $8, %rsp\n\t" // discard error code
>
Thanks, applied.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-27 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-27 20:23 [kvm-unit-tests][PATCH] x86: hypercall: fix compile error on i386 Chris J Arges
2015-01-27 20:27 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.