All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Andy Gross <agross@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	Kumar Gala <galak@codeaurora.org>,
	linux-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
Date: Wed, 28 Jan 2015 11:05:50 +0200	[thread overview]
Message-ID: <54C8A66E.3070306@mm-sol.com> (raw)
In-Reply-To: <1422396644-21714-2-git-send-email-agross@codeaurora.org>

Hi Andy,

On 01/28/2015 12:10 AM, Andy Gross wrote:
> This patch adds automatic configuration for the ADM CRCI muxing required to
> support DMA operations for GSBI clients.  The GSBI mode and instance determine
> the correct TCSR ADM CRCI MUX value that must be programmed so that the DMA
> works properly.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,gsbi.txt     |   17 ++-
>  drivers/soc/qcom/Kconfig                           |    1 +
>  drivers/soc/qcom/qcom_gsbi.c                       |  148 +++++++++++++++++++-
>  3 files changed, 158 insertions(+), 8 deletions(-)
> 

<snip>

> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 7bd2c94..32f20be 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -4,6 +4,7 @@
>  config QCOM_GSBI
>          tristate "QCOM General Serial Bus Interface"
>          depends on ARCH_QCOM
> +	select MFD_SYSCON

Wrong indentation? In fact the original Kconfig entry has spaces instead
of tabs, could you prepare a cleanup patch for this.

>          help
>            Say y here to enable GSBI support.  The GSBI provides control
>            functions for connecting the underlying serial UART, SPI, and I2C

<snip>

-- 
regards,
Stan

WARNING: multiple messages have this Message-ID (diff)
From: svarbanov@mm-sol.com (Stanimir Varbanov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
Date: Wed, 28 Jan 2015 11:05:50 +0200	[thread overview]
Message-ID: <54C8A66E.3070306@mm-sol.com> (raw)
In-Reply-To: <1422396644-21714-2-git-send-email-agross@codeaurora.org>

Hi Andy,

On 01/28/2015 12:10 AM, Andy Gross wrote:
> This patch adds automatic configuration for the ADM CRCI muxing required to
> support DMA operations for GSBI clients.  The GSBI mode and instance determine
> the correct TCSR ADM CRCI MUX value that must be programmed so that the DMA
> works properly.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,gsbi.txt     |   17 ++-
>  drivers/soc/qcom/Kconfig                           |    1 +
>  drivers/soc/qcom/qcom_gsbi.c                       |  148 +++++++++++++++++++-
>  3 files changed, 158 insertions(+), 8 deletions(-)
> 

<snip>

> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 7bd2c94..32f20be 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -4,6 +4,7 @@
>  config QCOM_GSBI
>          tristate "QCOM General Serial Bus Interface"
>          depends on ARCH_QCOM
> +	select MFD_SYSCON

Wrong indentation? In fact the original Kconfig entry has spaces instead
of tabs, could you prepare a cleanup patch for this.

>          help
>            Say y here to enable GSBI support.  The GSBI provides control
>            functions for connecting the underlying serial UART, SPI, and I2C

<snip>

-- 
regards,
Stan

WARNING: multiple messages have this Message-ID (diff)
From: Stanimir Varbanov <svarbanov@mm-sol.com>
To: Andy Gross <agross@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bjorn Andersson <bjorn.andersson@sonymobile.com>,
	devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
	linux-soc@vger.kernel.org
Subject: Re: [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
Date: Wed, 28 Jan 2015 11:05:50 +0200	[thread overview]
Message-ID: <54C8A66E.3070306@mm-sol.com> (raw)
In-Reply-To: <1422396644-21714-2-git-send-email-agross@codeaurora.org>

Hi Andy,

On 01/28/2015 12:10 AM, Andy Gross wrote:
> This patch adds automatic configuration for the ADM CRCI muxing required to
> support DMA operations for GSBI clients.  The GSBI mode and instance determine
> the correct TCSR ADM CRCI MUX value that must be programmed so that the DMA
> works properly.
> 
> Signed-off-by: Andy Gross <agross@codeaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,gsbi.txt     |   17 ++-
>  drivers/soc/qcom/Kconfig                           |    1 +
>  drivers/soc/qcom/qcom_gsbi.c                       |  148 +++++++++++++++++++-
>  3 files changed, 158 insertions(+), 8 deletions(-)
> 

<snip>

> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 7bd2c94..32f20be 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -4,6 +4,7 @@
>  config QCOM_GSBI
>          tristate "QCOM General Serial Bus Interface"
>          depends on ARCH_QCOM
> +	select MFD_SYSCON

Wrong indentation? In fact the original Kconfig entry has spaces instead
of tabs, could you prepare a cleanup patch for this.

>          help
>            Say y here to enable GSBI support.  The GSBI provides control
>            functions for connecting the underlying serial UART, SPI, and I2C

<snip>

-- 
regards,
Stan

  parent reply	other threads:[~2015-01-28  9:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 22:10 [PATCH 0/6] GSBI CRCI Autoconfiguration Support Andy Gross
2015-01-27 22:10 ` Andy Gross
2015-01-27 22:10 ` [PATCH 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing Andy Gross
2015-01-27 22:10   ` Andy Gross
2015-01-28  3:11   ` Bjorn Andersson
2015-01-28  3:11     ` Bjorn Andersson
2015-01-28 17:26     ` Andy Gross
2015-01-28 17:26       ` Andy Gross
2015-01-28  9:05   ` Stanimir Varbanov [this message]
2015-01-28  9:05     ` Stanimir Varbanov
2015-01-28  9:05     ` Stanimir Varbanov
2015-01-28 17:27     ` Andy Gross
2015-01-28 17:27       ` Andy Gross
2015-01-28 17:27       ` Andy Gross
2015-01-29  2:11   ` Stephen Boyd
2015-01-29  2:11     ` Stephen Boyd
2015-01-29  5:41     ` Andy Gross
2015-01-29  5:41       ` Andy Gross
2015-01-29  6:45       ` Stephen Boyd
2015-01-29  6:45         ` Stephen Boyd
2015-01-27 22:10 ` [PATCH 2/6] mfd: qcom,tcsr: Add device tree binding for TCSR Andy Gross
2015-01-27 22:10   ` Andy Gross
2015-01-27 22:10   ` Andy Gross
     [not found] ` <1422396644-21714-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-01-27 22:10   ` [PATCH 3/6] ARM: DT: apq8064: Add TCSR support Andy Gross
2015-01-27 22:10     ` Andy Gross
2015-01-27 22:10     ` Andy Gross
2015-01-27 22:10 ` [PATCH 4/6] ARM: DT: ipq8064: " Andy Gross
2015-01-27 22:10   ` Andy Gross
2015-01-27 22:10 ` [PATCH 5/6] ARM: DT: msm8660: " Andy Gross
2015-01-27 22:10   ` Andy Gross
2015-01-27 22:10 ` [PATCH 6/6] ARM: DT: msm8960: " Andy Gross
2015-01-27 22:10   ` Andy Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C8A66E.3070306@mm-sol.com \
    --to=svarbanov@mm-sol.com \
    --cc=agross@codeaurora.org \
    --cc=bjorn.andersson@sonymobile.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.