Re: [Qemu-trivial] [Qemu-devel] [PATCH 0/4] Pair g_malloc() with g_free(), not free()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On 01/28/2015 07:54 AM, Markus Armbruster wrote:
> I'm routing these patches through qemu-trivial, even though some of
> them touch actively maintained code, and could go through the
> respective tree instead:
> 
> * PATCH 3 sPAPR (Alex)
> 
> * PATCH 4 USB (Gerd)
> 
> If you want me to reroute any of them, let me know.

Reviewed-by: Eric Blake <eblake@redhat.com>

[for patches like these, sometimes I like to use git format-patch -U20
or whatever it takes to make the patch show full context of the
allocation a few lines earlier that matches with the actual g_free fix,
so that reviewers don't have to open the file themselves.  It makes for
larger emails, but potentially faster reviews.  But it's not the end of
the world to stick with the default 3-line context]

> 
> Markus Armbruster (4):
>   qemu-option: Replace pointless use of g_malloc0() by g_malloc()
>   qemu-option: Pair g_malloc() with g_free(), not free()
>   spapr_vio: Pair g_malloc() with g_free(), not free()
>   usb: Pair g_malloc() with g_free(), not free()
> 
>  hw/ppc/spapr_vio.c | 2 +-
>  hw/usb/desc-msos.c | 2 +-
>  util/qemu-option.c | 8 ++++----
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]