From: Gonglei <arei.gonglei@huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 1/4] qemu-option: Replace pointless use of g_malloc0() by g_malloc()
Date: Thu, 29 Jan 2015 08:20:03 +0800 [thread overview]
Message-ID: <54C97CB3.4050100@huawei.com> (raw)
In-Reply-To: <1422456844-13043-2-git-send-email-armbru@redhat.com>
On 2015/1/28 22:54, Markus Armbruster wrote:
> get_opt_value() takes a write-only buffer, so zeroing it is pointless.
> We don't do it elsewhere, either.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> util/qemu-option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
WARNING: multiple messages have this Message-ID (diff)
From: Gonglei <arei.gonglei@huawei.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] qemu-option: Replace pointless use of g_malloc0() by g_malloc()
Date: Thu, 29 Jan 2015 08:20:03 +0800 [thread overview]
Message-ID: <54C97CB3.4050100@huawei.com> (raw)
In-Reply-To: <1422456844-13043-2-git-send-email-armbru@redhat.com>
On 2015/1/28 22:54, Markus Armbruster wrote:
> get_opt_value() takes a write-only buffer, so zeroing it is pointless.
> We don't do it elsewhere, either.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> util/qemu-option.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
next prev parent reply other threads:[~2015-01-29 0:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-28 14:54 [Qemu-trivial] [PATCH 0/4] Pair g_malloc() with g_free(), not free() Markus Armbruster
2015-01-28 14:54 ` [Qemu-devel] " Markus Armbruster
2015-01-28 14:54 ` [Qemu-trivial] [PATCH 1/4] qemu-option: Replace pointless use of g_malloc0() by g_malloc() Markus Armbruster
2015-01-28 14:54 ` [Qemu-devel] " Markus Armbruster
2015-01-29 0:20 ` Gonglei [this message]
2015-01-29 0:20 ` Gonglei
2015-01-28 14:54 ` [Qemu-trivial] [PATCH 2/4] qemu-option: Pair g_malloc() with g_free(), not free() Markus Armbruster
2015-01-28 14:54 ` [Qemu-devel] " Markus Armbruster
2015-01-29 0:20 ` [Qemu-trivial] " Gonglei
2015-01-29 0:20 ` Gonglei
2015-01-28 14:54 ` [Qemu-trivial] [PATCH 3/4] spapr_vio: " Markus Armbruster
2015-01-28 14:54 ` [Qemu-devel] " Markus Armbruster
2015-01-29 0:20 ` [Qemu-trivial] " Gonglei
2015-01-29 0:20 ` Gonglei
2015-01-28 14:54 ` [Qemu-trivial] [PATCH 4/4] usb: " Markus Armbruster
2015-01-28 14:54 ` [Qemu-devel] " Markus Armbruster
2015-01-29 0:22 ` [Qemu-trivial] " Gonglei
2015-01-29 0:22 ` Gonglei
2015-01-28 15:13 ` [Qemu-trivial] [Qemu-devel] [PATCH 0/4] " Eric Blake
2015-01-28 15:13 ` Eric Blake
2015-02-04 9:43 ` [Qemu-trivial] " Markus Armbruster
2015-02-04 9:43 ` [Qemu-devel] " Markus Armbruster
2015-02-07 13:30 ` [Qemu-trivial] " Michael Tokarev
2015-02-07 13:30 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C97CB3.4050100@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.