From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicolas.ferre@atmel.com, Songjun.Wu@atmel.com,
linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown
Date: Mon, 9 Feb 2015 08:52:52 +0800 [thread overview]
Message-ID: <54D804E4.1000202@atmel.com> (raw)
In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk>
Hi Mark,
On 01/30/2015 09:20 PM, Mark Brown wrote:
> On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote:
>> In startup function, enable ssc clock and in shutdown function,
>> disable clock. And also remove disable ssc in shutdown function,
>> as ssc is disabled in prepare function.
>
> Applied, thanks. You probably want to convert to clk_prepare_enable()
> too but that's a separate thing.
OK, thanks, I will check that. As now, we prepare clock in ssc driver,
then enable it in dai driver.
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicolas.ferre@atmel.com, Songjun.Wu@atmel.com,
linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown
Date: Mon, 09 Feb 2015 00:52:52 +0000 [thread overview]
Message-ID: <54D804E4.1000202@atmel.com> (raw)
In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk>
Hi Mark,
On 01/30/2015 09:20 PM, Mark Brown wrote:
> On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote:
>> In startup function, enable ssc clock and in shutdown function,
>> disable clock. And also remove disable ssc in shutdown function,
>> as ssc is disabled in prepare function.
>
> Applied, thanks. You probably want to convert to clk_prepare_enable()
> too but that's a separate thing.
OK, thanks, I will check that. As now, we prepare clock in ssc driver,
then enable it in dai driver.
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: voice.shen@atmel.com (Bo Shen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown
Date: Mon, 9 Feb 2015 08:52:52 +0800 [thread overview]
Message-ID: <54D804E4.1000202@atmel.com> (raw)
In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk>
Hi Mark,
On 01/30/2015 09:20 PM, Mark Brown wrote:
> On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote:
>> In startup function, enable ssc clock and in shutdown function,
>> disable clock. And also remove disable ssc in shutdown function,
>> as ssc is disabled in prepare function.
>
> Applied, thanks. You probably want to convert to clk_prepare_enable()
> too but that's a separate thing.
OK, thanks, I will check that. As now, we prepare clock in ssc driver,
then enable it in dai driver.
Best Regards,
Bo Shen
WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <nicolas.ferre@atmel.com>, <Songjun.Wu@atmel.com>,
<linux-sound@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown
Date: Mon, 9 Feb 2015 08:52:52 +0800 [thread overview]
Message-ID: <54D804E4.1000202@atmel.com> (raw)
In-Reply-To: <20150130132047.GO26617@finisterre.sirena.org.uk>
Hi Mark,
On 01/30/2015 09:20 PM, Mark Brown wrote:
> On Fri, Jan 30, 2015 at 05:38:43PM +0800, Bo Shen wrote:
>> In startup function, enable ssc clock and in shutdown function,
>> disable clock. And also remove disable ssc in shutdown function,
>> as ssc is disabled in prepare function.
>
> Applied, thanks. You probably want to convert to clk_prepare_enable()
> too but that's a separate thing.
OK, thanks, I will check that. As now, we prepare clock in ssc driver,
then enable it in dai driver.
Best Regards,
Bo Shen
next prev parent reply other threads:[~2015-02-09 0:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 9:38 [PATCH 0/3] ASoC: atmel_ssc_dai: fix and refactor Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` [PATCH 1/3] ASoC: atmel_ssc_dai: fix the setting for DSP mode Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` [PATCH 2/3] ASoC: atmel_ssc_dai: refactor the startup and shutdown Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 13:20 ` Mark Brown
2015-01-30 13:20 ` Mark Brown
2015-01-30 13:20 ` Mark Brown
2015-02-09 0:52 ` Bo Shen [this message]
2015-02-09 0:52 ` Bo Shen
2015-02-09 0:52 ` Bo Shen
2015-02-09 0:52 ` Bo Shen
2015-01-30 9:38 ` [PATCH 3/3] ASoC: atmel_ssc_dai: only clean PDC when using PDC Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
2015-01-30 9:38 ` Bo Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D804E4.1000202@atmel.com \
--to=voice.shen@atmel.com \
--cc=Songjun.Wu@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.