From: Roger Quadros <rogerq@ti.com>
To: Robert Abel <rabel@cit-ec.uni-bielefeld.de>
Cc: khilman@deeprootsystems.com, Tony Lindgren <tony@atomide.com>,
linux@arm.linux.org.uk, linux-omap@vger.kernel.org,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children
Date: Tue, 17 Feb 2015 16:15:48 +0200 [thread overview]
Message-ID: <54E34D14.8080901@ti.com> (raw)
In-Reply-To: <CAMdRc4FXv1sgAJEOO410Z9YT1gdYUyfzfo__fn2gFaaRKa2jAA@mail.gmail.com>
On 17/02/15 15:57, Robert Abel wrote:
> Hi Roger,
>
> On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros <rogerq@ti.com> wrote:>
>> Can we simply use only
>> of_platform_populate(child, NULL, NULL, &pdev->dev)
>>
>> That way we get rid of the if..else and let OF core take care of
>> creating buses or devices.
>
> Surely, you mean
>
>> of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev);
>
> ? If matches is NULL, we won't match any busses. Or did you mean to
> just replace the second conditional?
I was wondering if just one call to of_platform_populate() is sufficient.
so you probably need "of_default_bus_match_table" for matches.
>
> I'll try that and see it works.
>
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Robert Abel <rabel@cit-ec.uni-bielefeld.de>
Cc: <khilman@deeprootsystems.com>, Tony Lindgren <tony@atomide.com>,
<linux@arm.linux.org.uk>, <linux-omap@vger.kernel.org>,
Linux Kernel Maling List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ARM OMAP2+ GPMC: add bus children
Date: Tue, 17 Feb 2015 16:15:48 +0200 [thread overview]
Message-ID: <54E34D14.8080901@ti.com> (raw)
In-Reply-To: <CAMdRc4FXv1sgAJEOO410Z9YT1gdYUyfzfo__fn2gFaaRKa2jAA@mail.gmail.com>
On 17/02/15 15:57, Robert Abel wrote:
> Hi Roger,
>
> On Tue, Feb 17, 2015 at 10:41 AM, Roger Quadros <rogerq@ti.com> wrote:>
>> Can we simply use only
>> of_platform_populate(child, NULL, NULL, &pdev->dev)
>>
>> That way we get rid of the if..else and let OF core take care of
>> creating buses or devices.
>
> Surely, you mean
>
>> of_platform_populate(child, of_default_bus_match_table, NULL, &pdev->dev);
>
> ? If matches is NULL, we won't match any busses. Or did you mean to
> just replace the second conditional?
I was wondering if just one call to of_platform_populate() is sufficient.
so you probably need "of_default_bus_match_table" for matches.
>
> I'll try that and see it works.
>
cheers,
-roger
next prev parent reply other threads:[~2015-02-17 14:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 15:48 [PATCH 0/4] ARM OMAP2+ GPMC: various fixes and bus children Robert ABEL
2015-02-16 15:48 ` [PATCH 1/4] ARM OMAP2+ GPMC: fix debug output alignment Robert ABEL
2015-02-16 15:48 ` [PATCH 2/4] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER Robert ABEL
2015-02-16 15:49 ` [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug Robert ABEL
2015-02-16 15:49 ` [PATCH 4/4] ARM OMAP2+ GPMC: add bus children Robert ABEL
2015-02-17 9:41 ` Roger Quadros
2015-02-17 9:41 ` Roger Quadros
2015-02-17 13:57 ` Robert Abel
2015-02-17 14:15 ` Roger Quadros [this message]
2015-02-17 14:15 ` Roger Quadros
2015-02-17 9:27 ` [PATCH 3/4] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug Roger Quadros
2015-02-17 9:27 ` Roger Quadros
2015-02-17 13:48 ` Robert Abel
2015-02-17 13:56 ` Roger Quadros
2015-02-17 13:56 ` Roger Quadros
2015-02-16 17:10 ` [PATCH 2/4] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER Tony Lindgren
2015-02-16 20:09 ` Robert Abel
2015-02-17 8:12 ` Roger Quadros
2015-02-17 8:12 ` Roger Quadros
2015-02-17 13:47 ` Robert Abel
[not found] ` <CAMdRc4F9B0ft-ExgQ1vHqwXMiONwWKn3FPCRDyHsjgGe1Dn_1w@mail.gmail.com>
2015-02-17 13:52 ` Roger Quadros
2015-02-17 13:52 ` Roger Quadros
2015-02-17 14:06 ` Robert Abel
2015-02-17 14:25 ` Roger Quadros
2015-02-17 14:25 ` Roger Quadros
2015-02-23 21:38 ` Robert Abel
2015-02-23 22:03 ` Tony Lindgren
2015-02-24 11:53 ` Roger Quadros
2015-02-24 11:53 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E34D14.8080901@ti.com \
--to=rogerq@ti.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rabel@cit-ec.uni-bielefeld.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.