From: julien.grall@linaro.org (Julien Grall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm/xen: Correctly check if the event channel interrupt is present
Date: Wed, 18 Feb 2015 11:50:35 +0000 [thread overview]
Message-ID: <54E47C8B.1080205@linaro.org> (raw)
In-Reply-To: <54E47A80.9050208@linaro.org>
On 18/02/2015 11:41, Julien Grall wrote:
> Hi Ian,
>
> On 18/02/2015 11:27, Ian Campbell wrote:
>> On Thu, 2015-02-12 at 06:34 +0000, Julien Grall wrote:
>>> The function irq_of_parse_and_map returns 0 when the IRQ is not found.
>>>
>>> Furthermore xen_events_irq is only read when the CPU is bring up, so
>>> it's not necessary to use the attribute __read_mostly.
>>
>> Part of the purpose of __read_mostly is to move such things out of
>> sharing cachelines with other more hot read/write things, as much as it
>> is to group all the "read only" things together.
>
> Hmmm... You are right. I didn't understand this macro like that.
>
> I will resend the series with this patch drop and add Ard's patch [1].
Actually I'm stupid... This patch is still useful except the __read_mostly.
>
> Regards,
>
> [1] https://patches.linaro.org/44633/
>
--
Julien Grall
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org, ard.biesheuvel@linaro.org,
linux-arm-kernel@lists.infradead.org,
stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH 1/2] arm/xen: Correctly check if the event channel interrupt is present
Date: Wed, 18 Feb 2015 11:50:35 +0000 [thread overview]
Message-ID: <54E47C8B.1080205@linaro.org> (raw)
In-Reply-To: <54E47A80.9050208@linaro.org>
On 18/02/2015 11:41, Julien Grall wrote:
> Hi Ian,
>
> On 18/02/2015 11:27, Ian Campbell wrote:
>> On Thu, 2015-02-12 at 06:34 +0000, Julien Grall wrote:
>>> The function irq_of_parse_and_map returns 0 when the IRQ is not found.
>>>
>>> Furthermore xen_events_irq is only read when the CPU is bring up, so
>>> it's not necessary to use the attribute __read_mostly.
>>
>> Part of the purpose of __read_mostly is to move such things out of
>> sharing cachelines with other more hot read/write things, as much as it
>> is to group all the "read only" things together.
>
> Hmmm... You are right. I didn't understand this macro like that.
>
> I will resend the series with this patch drop and add Ard's patch [1].
Actually I'm stupid... This patch is still useful except the __read_mostly.
>
> Regards,
>
> [1] https://patches.linaro.org/44633/
>
--
Julien Grall
next prev parent reply other threads:[~2015-02-18 11:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 6:34 [PATCH 0/2] arm/arm64: Detect Xen support earlier Julien Grall
2015-02-12 6:34 ` [PATCH 1/2] arm/xen: Correctly check if the event channel interrupt is present Julien Grall
2015-02-12 6:34 ` Julien Grall
2015-02-18 11:27 ` Ian Campbell
2015-02-18 11:27 ` Ian Campbell
2015-02-18 11:41 ` Julien Grall
2015-02-18 11:50 ` Julien Grall [this message]
2015-02-18 11:50 ` Julien Grall
2015-02-18 11:41 ` Julien Grall
2015-02-12 6:34 ` [PATCH 2/2] arm, arm64/xen: move Xen initialization earlier Julien Grall
2015-02-12 6:34 ` [PATCH 2/2] arm,arm64/xen: " Julien Grall
2015-02-12 11:27 ` [PATCH 0/2] arm/arm64: Detect Xen support earlier Ard Biesheuvel
2015-02-12 11:27 ` Ard Biesheuvel
2015-02-18 11:30 ` Ian Campbell
2015-02-18 11:30 ` Ian Campbell
2015-02-18 11:51 ` Julien Grall
2015-02-18 11:51 ` Julien Grall
2015-02-18 12:03 ` Ian Campbell
2015-02-18 12:13 ` Julien Grall
2015-02-18 12:13 ` Julien Grall
2015-02-18 13:40 ` Ian Campbell
2015-02-18 13:40 ` Ian Campbell
2015-02-18 12:03 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E47C8B.1080205@linaro.org \
--to=julien.grall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.