From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support
Date: Thu, 19 Feb 2015 17:02:56 +0000 [thread overview]
Message-ID: <54E61740.8030708@cogentembedded.com> (raw)
In-Reply-To: <20150219161012.GA3864@verge.net.au>
Hello.
On 02/19/2015 07:10 PM, Simon Horman wrote:
>> Define the generic R8A7794 part of the MMCIF0 device node.
>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> arch/arm/boot/dts/r8a7794.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> =================================>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>> status = "disabled";
>> };
>>
>> + mmcif0: mmc@ee200000 {
>> + compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.
That file doesn't match the reality at all. It says:
<<
- compatible: must contain one of the following
- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
- "renesas,sh-mmcif" for the generic MMCIF
>>
while in reality, the driver only matches on the latter string and doesn't
care for the SoC specific strings.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support
Date: Thu, 19 Feb 2015 20:02:56 +0300 [thread overview]
Message-ID: <54E61740.8030708@cogentembedded.com> (raw)
In-Reply-To: <20150219161012.GA3864@verge.net.au>
Hello.
On 02/19/2015 07:10 PM, Simon Horman wrote:
>> Define the generic R8A7794 part of the MMCIF0 device node.
>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> arch/arm/boot/dts/r8a7794.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>> status = "disabled";
>> };
>>
>> + mmcif0: mmc at ee200000 {
>> + compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.
That file doesn't match the reality at all. It says:
<<
- compatible: must contain one of the following
- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
- "renesas,sh-mmcif" for the generic MMCIF
>>
while in reality, the driver only matches on the latter string and doesn't
care for the SoC specific strings.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-sh@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org,
magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support
Date: Thu, 19 Feb 2015 20:02:56 +0300 [thread overview]
Message-ID: <54E61740.8030708@cogentembedded.com> (raw)
In-Reply-To: <20150219161012.GA3864@verge.net.au>
Hello.
On 02/19/2015 07:10 PM, Simon Horman wrote:
>> Define the generic R8A7794 part of the MMCIF0 device node.
>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> arch/arm/boot/dts/r8a7794.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>> @@ -346,6 +346,17 @@
>> status = "disabled";
>> };
>>
>> + mmcif0: mmc@ee200000 {
>> + compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
> Please submit a patch to add "renesas,mmcif-r8a7794" to
> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
> I looked and I couldn't find such a change in-tree or in-flight.
That file doesn't match the reality at all. It says:
<<
- compatible: must contain one of the following
- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
- "renesas,sh-mmcif" for the generic MMCIF
>>
while in reality, the driver only matches on the latter string and doesn't
care for the SoC specific strings.
WBR, Sergei
next prev parent reply other threads:[~2015-02-19 17:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 22:57 [PATCH 0/2 resend] Add R8A7794/SILK board eMMC DT support Sergei Shtylyov
2015-02-16 22:57 ` Sergei Shtylyov
2015-02-16 22:57 ` Sergei Shtylyov
2015-02-16 22:59 ` [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF " Sergei Shtylyov
2015-02-16 22:59 ` Sergei Shtylyov
2015-02-16 22:59 ` Sergei Shtylyov
2015-02-19 16:10 ` Simon Horman
2015-02-19 16:10 ` Simon Horman
2015-02-19 16:10 ` Simon Horman
2015-02-19 17:02 ` Sergei Shtylyov [this message]
2015-02-19 17:02 ` Sergei Shtylyov
2015-02-19 17:02 ` Sergei Shtylyov
2015-02-19 17:55 ` Simon Horman
2015-02-19 17:55 ` Simon Horman
2015-02-19 17:55 ` Simon Horman
2015-02-19 19:13 ` Sergei Shtylyov
2015-02-19 19:13 ` Sergei Shtylyov
2015-02-19 19:13 ` Sergei Shtylyov
2015-02-16 23:00 ` [PATCH 2/2] ARM: shmobile: silk: add eMMC " Sergei Shtylyov
2015-02-16 23:00 ` Sergei Shtylyov
2015-02-16 23:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E61740.8030708@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.