[PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[Ksenija Stanojevic]

This patch fixes the following checkpatch.pl warning:
Use #include <linux/string.h> instead of <asm/string.h>

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
index 5533221..80dfa07 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
@@ -15,7 +15,7 @@
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
-#include <asm/string.h>
+#include <linux/string.h>
 #include <asm/errno.h>
 
 #include "ieee80211.h"
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[Jes Sorensen]

On 02/20/15 14:32, Ksenija Stanojevic wrote:
> This patch fixes the following checkpatch.pl warning:
> Use #include <linux/string.h> instead of <asm/string.h>
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..80dfa07 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -15,7 +15,7 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> -#include <asm/string.h>
> +#include <linux/string.h>
>  #include <asm/errno.h>
>  
>  #include "ieee80211.h"
> 

I just noticed you were generating two patches for very similar changes
errno.h and string.h. Since these changes are to the same file and
basically identical changes, doing them both in one patch is preferred.

Cheers,
Jes

Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[Ksenija Stanojević]

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

Ok. Should i make a separate patch or v2 of one of them?

On Fri, Feb 20, 2015 at 8:47 PM, Jes Sorensen <jes.sorensen@gmail.com>
wrote:

> On 02/20/15 14:32, Ksenija Stanojevic wrote:
> > This patch fixes the following checkpatch.pl warning:
> > Use #include <linux/string.h> instead of <asm/string.h>
> >
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> > ---
> >  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> > index 5533221..80dfa07 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> > @@ -15,7 +15,7 @@
> >  #include <linux/module.h>
> >  #include <linux/init.h>
> >  #include <linux/slab.h>
> > -#include <asm/string.h>
> > +#include <linux/string.h>
> >  #include <asm/errno.h>
> >
> >  #include "ieee80211.h"
> >
>
> I just noticed you were generating two patches for very similar changes
> errno.h and string.h. Since these changes are to the same file and
> basically identical changes, doing them both in one patch is preferred.
>
> Cheers,
> Jes
>
>

[-- Attachment #2: Type: text/html, Size: 1945 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2265 bytes --]

On Fri, 20 Feb 2015, Ksenija Stanojević wrote:

> Ok. Should i make a separate patch or v2 of one of them?

Don't top post.  In reading this message on a small screen one has not 
idea what comment this is responding to.  See

http://kernelnewbies.org/Outreachyfirstpatch

in the section about responding to emails.

julia

> On Fri, Feb 20, 2015 at 8:47 PM, Jes Sorensen <jes.sorensen@gmail.com>
> wrote:
>       On 02/20/15 14:32, Ksenija Stanojevic wrote:
>       > This patch fixes the following checkpatch.pl warning:
>       > Use #include <linux/string.h> instead of <asm/string.h>
>       >
>       > Signed-off-by: Ksenija Stanojevic
>       <ksenija.stanojevic@gmail.com>
>       > ---
>       >  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
>       >  1 file changed, 1 insertion(+), 1 deletion(-)
>       >
>       > diff --git
>       a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>       b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>       > index 5533221..80dfa07 100644
>       > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>       > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>       > @@ -15,7 +15,7 @@
>       >  #include <linux/module.h>
>       >  #include <linux/init.h>
>       >  #include <linux/slab.h>
>       > -#include <asm/string.h>
>       > +#include <linux/string.h>
>       >  #include <asm/errno.h>
>       >
>       >  #include "ieee80211.h"
>       >
> 
> I just noticed you were generating two patches for very similar
> changes
> errno.h and string.h. Since these changes are to the same file and
> basically identical changes, doing them both in one patch is
> preferred.
> 
> Cheers,
> Jes
> 
> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAL7P5j%2BucoNiBEbRfkwZF
> ObjPxH8%3Di0yMQTNxsoCj8fubdbSHw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[Jes Sorensen]

On 02/20/15 15:45, Ksenija Stanojević wrote:
> Ok. Should i make a separate patch or v2 of one of them?

Yes please merge and repost - and as Julia said, please don't top-post
it's bad email etiquette. Community people generally frown upon it.

Jes

> On Fri, Feb 20, 2015 at 8:47 PM, Jes Sorensen <jes.sorensen@gmail.com>
> wrote:
> 
>> On 02/20/15 14:32, Ksenija Stanojevic wrote:
>>> This patch fixes the following checkpatch.pl warning:
>>> Use #include <linux/string.h> instead of <asm/string.h>
>>>
>>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>>> ---
>>>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>> b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>>> index 5533221..80dfa07 100644
>>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
>>> @@ -15,7 +15,7 @@
>>>  #include <linux/module.h>
>>>  #include <linux/init.h>
>>>  #include <linux/slab.h>
>>> -#include <asm/string.h>
>>> +#include <linux/string.h>
>>>  #include <asm/errno.h>
>>>
>>>  #include "ieee80211.h"
>>>
>>
>> I just noticed you were generating two patches for very similar changes
>> errno.h and string.h. Since these changes are to the same file and
>> basically identical changes, doing them both in one patch is preferred.
>>
>> Cheers,
>> Jes
>>
>>
>