All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	David Gibson <david@gibson.dropbear.id.au>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	qemu-ppc Mailing List <qemu-ppc@nongnu.org>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
	Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 1/3] Add specific config options for PCI-E bridges
Date: Tue, 24 Feb 2015 09:38:58 -0700	[thread overview]
Message-ID: <54ECA922.8050306@redhat.com> (raw)
In-Reply-To: <CAEgOgz5Z=anoTTcuA1goc_ufouOJE9=zhDnbdavDqwCtZq8ivA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On 02/23/2015 11:17 PM, Peter Crosthwaite wrote:
> On Mon, Feb 23, 2015 at 3:05 PM, David Gibson
> <david@gibson.dropbear.id.au> wrote:
>> The i82801b11, ioh3420 and xio3130 PCI Express devices are currently
>> included in the build unconditionally.
>>
>> While they could theoretically appear on any target platform with PCI-E,
>> they're pretty unlikely to appear on platforms that aren't Intel derived.
>>
>> Therefore, to avoid presenting unlikely-to-be-relevant devices to the user,
>> add config options to enable these componenets, and enable they by default
> 
> "components", "them"
> 
>> only on x86 and arm platforms.
>>
>> (Note that this patch does include these for aarch64, via its inclusion of
>> arm-softmmu.mak).
>>
> 
> "it's"

"it's" is only correct when you can replace "it is" (or "it has"); this
is a place where "its" is correct.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

  parent reply	other threads:[~2015-02-24 16:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 23:04 [Qemu-devel] [PATCH 0/3] Add config options for some not-always-sensible devices David Gibson
2015-02-23 23:05 ` [Qemu-devel] [PATCH 1/3] Add specific config options for PCI-E bridges David Gibson
2015-02-24  6:17   ` Peter Crosthwaite
2015-02-24  8:55     ` David Gibson
2015-02-24 16:44       ` Peter Crosthwaite
2015-02-24 16:38     ` Eric Blake [this message]
2015-02-23 23:05 ` [Qemu-devel] [PATCH 2/3] Create specific config option for "platform-bus" David Gibson
2015-02-24  6:27   ` Peter Crosthwaite
2015-02-24  8:57     ` David Gibson
2015-02-26  8:26       ` Peter Crosthwaite
2015-02-23 23:05 ` [Qemu-devel] [PATCH 3/3] Give ivshmem its own config option David Gibson
2015-02-24  6:38   ` Peter Crosthwaite
2015-02-24  8:57     ` David Gibson
2015-02-26  8:29       ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ECA922.8050306@redhat.com \
    --to=eblake@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.