Re: [Qemu-devel] [PATCH 3/3] Give ivshmem its own config option

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]

On Mon, Feb 23, 2015 at 10:38:06PM -0800, Peter Crosthwaite wrote:
> On Mon, Feb 23, 2015 at 3:05 PM, David Gibson
> <david@gibson.dropbear.id.au> wrote:
> > Currently the ivshmem device is built whenever both PCI and KVM support are
> > included.  This patch gives it its own config option to allow easier
> > customization of whether to include it.  It's enabled by default in the
> > same circumstances as now - when both PCI and KVM are available.
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> >  default-configs/pci.mak | 1 +
> >  hw/misc/Makefile.objs   | 4 +---
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> > index bea6b01..58a2c0a 100644
> > --- a/default-configs/pci.mak
> > +++ b/default-configs/pci.mak
> > @@ -35,3 +35,4 @@ CONFIG_SDHCI=y
> >  CONFIG_EDU=y
> >  CONFIG_VGA=y
> >  CONFIG_VGA_PCI=y
> > +CONFIG_IVSHMEM=$(CONFIG_KVM)
> 
> Does this create an order of definition requirement between the
> configs? I guess its ok as CONFIG_KVM is defined super-early but it
> seems to be avoided where one config def depends on another.

Actually, I don't think it does.  When "=" is used, rather than ":="
make variables are expanded when used, not when defined.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]