Re: [Qemu-devel] [PATCH 2/3] Create specific config option for "platform-bus"

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

On Mon, Feb 23, 2015 at 10:27:20PM -0800, Peter Crosthwaite wrote:
> On Mon, Feb 23, 2015 at 3:05 PM, David Gibson
> <david@gibson.dropbear.id.au> wrote:
> > Currently the "platform-bus" device is included for all softmmu builds.
> > This bridge is intended for use on any platforms that require dynamic
> > creation of sysbus devices.  However, at present it is used only for the
> > PPC E500 target, with plans for the ARM "virt" target in the immediate
> > future.
> >
> > To avoid a not-very-useful entry appearing in "qemu -device ?" output on
> > other targets, this patch makes a specific config option for platform-bus
> > and enables it (for now) only on ppc configurations which include E500
> > and on ARM (which always includes the "virt" target).
> >
> > Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> > ---
> >  default-configs/arm-softmmu.mak   | 1 +
> >  default-configs/ppc-softmmu.mak   | 1 +
> >  default-configs/ppc64-softmmu.mak | 1 +
> >  hw/core/Makefile.objs             | 2 +-
> >  4 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> > index 6ee9b43..cc2745f 100644
> > --- a/default-configs/arm-softmmu.mak
> > +++ b/default-configs/arm-softmmu.mak
> > @@ -79,6 +79,7 @@ CONFIG_NSERIES=y
> >  CONFIG_REALVIEW=y
> >  CONFIG_ZAURUS=y
> >  CONFIG_ZYNQ=y
> > +CONFIG_PLATFORM_BUS=y
> >
> 
> This location might not fit best for this config. REALVIEW, and ZYNQ
> are ARM specific boards and this logical grouping of configs seems to
> be about ARM boards and their specific devs.
> 
> Should it just be in it's own category? Alternatively, the first block
> of configs seems to contain all the generic stuff (like SSI, SD,
> SERIAL and pci.mak) so I think it fits in that bucket most closely.

I really don't know ARM well enough to have any intuition on this.
I'm happy to put it wherever I'm told is best.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]