From: Eric Blake <eblake@redhat.com>
To: Cole Robinson <crobinso@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore
Date: Fri, 27 Feb 2015 09:33:27 -0700 [thread overview]
Message-ID: <54F09C57.3030702@redhat.com> (raw)
In-Reply-To: <60b9a8741264d4fc7042ae560ea859cd62babd1e.1425050482.git.crobinso@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On 02/27/2015 08:21 AM, Cole Robinson wrote:
> Rather than track it in the toplevel gitignore
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> .gitignore | 1 -
> tests/qemu-iotests/.gitignore | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
I think that the fact that we have multiple .gitignore is confusing, and
would personally lean towards a patch that consolidates ALL ignores into
a single top-level file, instead of having to hunt multiple files for
patterns. But my opinion on this matter is not strong enough for me to
provide a patch at this time...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Cole Robinson <crobinso@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial <qemu-trivial@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore
Date: Fri, 27 Feb 2015 09:33:27 -0700 [thread overview]
Message-ID: <54F09C57.3030702@redhat.com> (raw)
In-Reply-To: <60b9a8741264d4fc7042ae560ea859cd62babd1e.1425050482.git.crobinso@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On 02/27/2015 08:21 AM, Cole Robinson wrote:
> Rather than track it in the toplevel gitignore
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> .gitignore | 1 -
> tests/qemu-iotests/.gitignore | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
I think that the fact that we have multiple .gitignore is confusing, and
would personally lean towards a patch that consolidates ALL ignores into
a single top-level file, instead of having to hunt multiple files for
patterns. But my opinion on this matter is not strong enough for me to
provide a patch at this time...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-27 16:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 15:21 [Qemu-trivial] [PATCH] gitignore: Track common.env in iotests gitignore Cole Robinson
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
2015-02-27 15:21 ` [Qemu-trivial] [PATCH] gitignore: Ignore new tests Cole Robinson
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
2015-02-27 16:33 ` Eric Blake [this message]
2015-02-27 16:33 ` [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore Eric Blake
2015-02-28 9:56 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:56 ` [Qemu-devel] " Michael Tokarev
2015-02-28 9:56 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:56 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F09C57.3030702@redhat.com \
--to=eblake@redhat.com \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.