* [Qemu-trivial] [PATCH] gitignore: Track common.env in iotests gitignore
@ 2015-02-27 15:21 ` Cole Robinson
0 siblings, 0 replies; 10+ messages in thread
From: Cole Robinson @ 2015-02-27 15:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Cole Robinson
Rather than track it in the toplevel gitignore
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
.gitignore | 1 -
tests/qemu-iotests/.gitignore | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 090f974..e32a584 100644
--- a/.gitignore
+++ b/.gitignore
@@ -109,4 +109,3 @@ cscope.*
tags
TAGS
*~
-/tests/qemu-iotests/common.env
diff --git a/tests/qemu-iotests/.gitignore b/tests/qemu-iotests/.gitignore
index 0541f80..0711cbd 100644
--- a/tests/qemu-iotests/.gitignore
+++ b/tests/qemu-iotests/.gitignore
@@ -1,5 +1,6 @@
check.log
check.time
+common.env
*.out.bad
*.notrun
socket_scm_helper
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore
@ 2015-02-27 15:21 ` Cole Robinson
0 siblings, 0 replies; 10+ messages in thread
From: Cole Robinson @ 2015-02-27 15:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Cole Robinson
Rather than track it in the toplevel gitignore
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
.gitignore | 1 -
tests/qemu-iotests/.gitignore | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
index 090f974..e32a584 100644
--- a/.gitignore
+++ b/.gitignore
@@ -109,4 +109,3 @@ cscope.*
tags
TAGS
*~
-/tests/qemu-iotests/common.env
diff --git a/tests/qemu-iotests/.gitignore b/tests/qemu-iotests/.gitignore
index 0541f80..0711cbd 100644
--- a/tests/qemu-iotests/.gitignore
+++ b/tests/qemu-iotests/.gitignore
@@ -1,5 +1,6 @@
check.log
check.time
+common.env
*.out.bad
*.notrun
socket_scm_helper
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Qemu-trivial] [PATCH] gitignore: Ignore new tests
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
@ 2015-02-27 15:21 ` Cole Robinson
-1 siblings, 0 replies; 10+ messages in thread
From: Cole Robinson @ 2015-02-27 15:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Cole Robinson
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
tests/.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index e2e4957..0dcb618 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -5,6 +5,7 @@ check-qjson
check-qlist
check-qstring
check-qom-interface
+rcutorture
test-aio
test-bitops
test-coroutine
@@ -26,6 +27,7 @@ test-qmp-input-strict
test-qmp-input-visitor
test-qmp-marshal.c
test-qmp-output-visitor
+test-rcu-list
test-rfifolock
test-string-input-visitor
test-string-output-visitor
@@ -33,6 +35,7 @@ test-thread-pool
test-throttle
test-visitor-serialization
test-vmstate
+test-write-threshold
test-x86-cpuid
test-xbzrle
*-test
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH] gitignore: Ignore new tests
@ 2015-02-27 15:21 ` Cole Robinson
0 siblings, 0 replies; 10+ messages in thread
From: Cole Robinson @ 2015-02-27 15:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Cole Robinson
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
tests/.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index e2e4957..0dcb618 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -5,6 +5,7 @@ check-qjson
check-qlist
check-qstring
check-qom-interface
+rcutorture
test-aio
test-bitops
test-coroutine
@@ -26,6 +27,7 @@ test-qmp-input-strict
test-qmp-input-visitor
test-qmp-marshal.c
test-qmp-output-visitor
+test-rcu-list
test-rfifolock
test-string-input-visitor
test-string-output-visitor
@@ -33,6 +35,7 @@ test-thread-pool
test-throttle
test-visitor-serialization
test-vmstate
+test-write-threshold
test-x86-cpuid
test-xbzrle
*-test
--
2.1.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
@ 2015-02-27 16:33 ` Eric Blake
-1 siblings, 0 replies; 10+ messages in thread
From: Eric Blake @ 2015-02-27 16:33 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On 02/27/2015 08:21 AM, Cole Robinson wrote:
> Rather than track it in the toplevel gitignore
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> .gitignore | 1 -
> tests/qemu-iotests/.gitignore | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
I think that the fact that we have multiple .gitignore is confusing, and
would personally lean towards a patch that consolidates ALL ignores into
a single top-level file, instead of having to hunt multiple files for
patterns. But my opinion on this matter is not strong enough for me to
provide a patch at this time...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore
@ 2015-02-27 16:33 ` Eric Blake
0 siblings, 0 replies; 10+ messages in thread
From: Eric Blake @ 2015-02-27 16:33 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 730 bytes --]
On 02/27/2015 08:21 AM, Cole Robinson wrote:
> Rather than track it in the toplevel gitignore
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> .gitignore | 1 -
> tests/qemu-iotests/.gitignore | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
I think that the fact that we have multiple .gitignore is confusing, and
would personally lean towards a patch that consolidates ALL ignores into
a single top-level file, instead of having to hunt multiple files for
patterns. But my opinion on this matter is not strong enough for me to
provide a patch at this time...
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] gitignore: Track common.env in iotests gitignore
2015-02-27 16:33 ` Eric Blake
@ 2015-02-28 9:56 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-02-28 9:56 UTC (permalink / raw)
To: Eric Blake, Cole Robinson, qemu-devel; +Cc: qemu-trivial
27.02.2015 19:33, Eric Blake wrote:
> On 02/27/2015 08:21 AM, Cole Robinson wrote:
>> Rather than track it in the toplevel gitignore
>>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
>> .gitignore | 1 -
>> tests/qemu-iotests/.gitignore | 1 +
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> I think that the fact that we have multiple .gitignore is confusing, and
> would personally lean towards a patch that consolidates ALL ignores into
> a single top-level file, instead of having to hunt multiple files for
> patterns. But my opinion on this matter is not strong enough for me to
> provide a patch at this time...
Since tests/ is kind of special because it generates so many
various files in there, I think it is reasonable to have separate
.gitignore files in there.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore
@ 2015-02-28 9:56 ` Michael Tokarev
0 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-02-28 9:56 UTC (permalink / raw)
To: Eric Blake, Cole Robinson, qemu-devel; +Cc: qemu-trivial
27.02.2015 19:33, Eric Blake wrote:
> On 02/27/2015 08:21 AM, Cole Robinson wrote:
>> Rather than track it in the toplevel gitignore
>>
>> Signed-off-by: Cole Robinson <crobinso@redhat.com>
>> ---
>> .gitignore | 1 -
>> tests/qemu-iotests/.gitignore | 1 +
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> I think that the fact that we have multiple .gitignore is confusing, and
> would personally lean towards a patch that consolidates ALL ignores into
> a single top-level file, instead of having to hunt multiple files for
> patterns. But my opinion on this matter is not strong enough for me to
> provide a patch at this time...
Since tests/ is kind of special because it generates so many
various files in there, I think it is reasonable to have separate
.gitignore files in there.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] gitignore: Track common.env in iotests gitignore
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
@ 2015-02-28 9:56 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-02-28 9:56 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: qemu-trivial
Applied both to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-02-28 9:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-27 15:21 [Qemu-trivial] [PATCH] gitignore: Track common.env in iotests gitignore Cole Robinson
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
2015-02-27 15:21 ` [Qemu-trivial] [PATCH] gitignore: Ignore new tests Cole Robinson
2015-02-27 15:21 ` [Qemu-devel] " Cole Robinson
2015-02-27 16:33 ` [Qemu-trivial] [Qemu-devel] [PATCH] gitignore: Track common.env in iotests gitignore Eric Blake
2015-02-27 16:33 ` Eric Blake
2015-02-28 9:56 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:56 ` [Qemu-devel] " Michael Tokarev
2015-02-28 9:56 ` [Qemu-trivial] " Michael Tokarev
2015-02-28 9:56 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.