All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-trivial@nongnu.org, Amit Shah <amit.shah@redhat.com>,
	qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit
Date: Sat, 28 Feb 2015 12:26:41 +0300	[thread overview]
Message-ID: <54F189D1.10908@msgid.tls.msk.ru> (raw)
In-Reply-To: <20150219102500.GA2305@work-vm>

19.02.2015 13:25, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (mjt@tls.msk.ru) wrote:
>> Do not check for rdma->host being empty twice.  This removes a large
>> "if" block, so code indentation is changed.  While at it, remove an
>> ugly goto from the loop, replacing it with a cleaner if logic.  And
>> finally, there's no need to initialize `ret' variable since is always
>> has a value.
> 
> This looks OK; have you got RDMA hardware to test with, if not I can
> give it a go.

No, I don't have any RDMA hw, I only compile-tested this code, and
double-checked the changes does not change behavour.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-trivial@nongnu.org, Amit Shah <amit.shah@redhat.com>,
	qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit
Date: Sat, 28 Feb 2015 12:26:41 +0300	[thread overview]
Message-ID: <54F189D1.10908@msgid.tls.msk.ru> (raw)
In-Reply-To: <20150219102500.GA2305@work-vm>

19.02.2015 13:25, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (mjt@tls.msk.ru) wrote:
>> Do not check for rdma->host being empty twice.  This removes a large
>> "if" block, so code indentation is changed.  While at it, remove an
>> ugly goto from the loop, replacing it with a cleaner if logic.  And
>> finally, there's no need to initialize `ret' variable since is always
>> has a value.
> 
> This looks OK; have you got RDMA hardware to test with, if not I can
> give it a go.

No, I don't have any RDMA hw, I only compile-tested this code, and
double-checked the changes does not change behavour.

Thanks,

/mjt

  reply	other threads:[~2015-02-28  9:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-16  7:50 [Qemu-trivial] [PATCH] migration/rdma: clean up qemu_rdma_dest_init a bit Michael Tokarev
2015-02-16  7:50 ` [Qemu-devel] " Michael Tokarev
2015-02-19 10:25 ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-02-19 10:25   ` Dr. David Alan Gilbert
2015-02-28  9:26   ` Michael Tokarev [this message]
2015-02-28  9:26     ` Michael Tokarev
2015-03-04 12:16 ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-04 12:16   ` Dr. David Alan Gilbert
2015-03-04 12:22   ` [Qemu-trivial] " Michael Tokarev
2015-03-04 12:22     ` Michael Tokarev
2015-03-04 13:32     ` [Qemu-trivial] " Dr. David Alan Gilbert
2015-03-04 13:32       ` Dr. David Alan Gilbert
2015-03-04 13:34       ` [Qemu-trivial] " Michael Tokarev
2015-03-04 13:34         ` [Qemu-devel] " Michael Tokarev
2015-03-17 13:10 ` [Qemu-trivial] " Juan Quintela
2015-03-17 13:10   ` [Qemu-devel] " Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54F189D1.10908@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.