* [PATCH] xen: Remove trailing semicolon of macro so it can be used in 'if' statement
@ 2015-03-01 10:57 Yuval Shaia
2015-03-02 10:39 ` David Vrabel
0 siblings, 1 reply; 2+ messages in thread
From: Yuval Shaia @ 2015-03-01 10:57 UTC (permalink / raw)
To: yuval.shaia, xen-devel
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
include/xen/xenbus.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
index b78f21c..b0f1c9e 100644
--- a/include/xen/xenbus.h
+++ b/include/xen/xenbus.h
@@ -114,9 +114,9 @@ int __must_check __xenbus_register_backend(struct xenbus_driver *drv,
const char *mod_name);
#define xenbus_register_frontend(drv) \
- __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME);
+ __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME)
#define xenbus_register_backend(drv) \
- __xenbus_register_backend(drv, THIS_MODULE, KBUILD_MODNAME);
+ __xenbus_register_backend(drv, THIS_MODULE, KBUILD_MODNAME)
void xenbus_unregister_driver(struct xenbus_driver *drv);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen: Remove trailing semicolon of macro so it can be used in 'if' statement
2015-03-01 10:57 [PATCH] xen: Remove trailing semicolon of macro so it can be used in 'if' statement Yuval Shaia
@ 2015-03-02 10:39 ` David Vrabel
0 siblings, 0 replies; 2+ messages in thread
From: David Vrabel @ 2015-03-02 10:39 UTC (permalink / raw)
To: Yuval Shaia, xen-devel
On 01/03/15 10:57, Yuval Shaia wrote:
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> include/xen/xenbus.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/xen/xenbus.h b/include/xen/xenbus.h
> index b78f21c..b0f1c9e 100644
> --- a/include/xen/xenbus.h
> +++ b/include/xen/xenbus.h
> @@ -114,9 +114,9 @@ int __must_check __xenbus_register_backend(struct xenbus_driver *drv,
> const char *mod_name);
>
> #define xenbus_register_frontend(drv) \
> - __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME);
> + __xenbus_register_frontend(drv, THIS_MODULE, KBUILD_MODNAME)
Oops. Applied to stable/for-linus-4,0, thanks.
However, the preferred style for a caller would be:
ret = xenbus_register_frontend(...);
if (ret < 0) {
...
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-02 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-01 10:57 [PATCH] xen: Remove trailing semicolon of macro so it can be used in 'if' statement Yuval Shaia
2015-03-02 10:39 ` David Vrabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.