* [PATCH] ASoC: omap-pcm: Correct dma mask
@ 2015-03-03 11:38 Peter Ujfalusi
2015-03-03 14:08 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2015-03-03 11:38 UTC (permalink / raw)
To: Mark Brown, Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood
DMA_BIT_MASK of 64 is not valid dma address mask for OMAPs, it should be
set to 32.
The 64 was introduced by commit (in 2009):
a152ff24b978 ASoC: OMAP: Make DMA 64 aligned
But the dma_mask and coherent_dma_mask can not be used to specify alignment.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/omap/omap-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 54d59e4f8f5f..d52a6d1ae55d 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -227,7 +227,7 @@ static int omap_pcm_new(struct snd_soc_pcm_runtime *rtd)
struct snd_pcm *pcm = rtd->pcm;
int ret;
- ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(64));
+ ret = dma_coerce_mask_and_coherent(card->dev, DMA_BIT_MASK(32));
if (ret)
return ret;
--
2.3.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap-pcm: Correct dma mask
2015-03-03 11:38 [PATCH] ASoC: omap-pcm: Correct dma mask Peter Ujfalusi
@ 2015-03-03 14:08 ` Mark Brown
2015-03-03 14:36 ` Peter Ujfalusi
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2015-03-03 14:08 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood, Jarkko Nikula
[-- Attachment #1.1: Type: text/plain, Size: 262 bytes --]
On Tue, Mar 03, 2015 at 01:38:14PM +0200, Peter Ujfalusi wrote:
> DMA_BIT_MASK of 64 is not valid dma address mask for OMAPs, it should be
> set to 32.
> The 64 was introduced by commit (in 2009):
> a152ff24b978 ASoC: OMAP: Make DMA 64 aligned
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap-pcm: Correct dma mask
2015-03-03 14:08 ` Mark Brown
@ 2015-03-03 14:36 ` Peter Ujfalusi
2015-03-04 17:23 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Peter Ujfalusi @ 2015-03-03 14:36 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Liam Girdwood, Jarkko Nikula
Mark,
On 03/03/2015 04:08 PM, Mark Brown wrote:
> On Tue, Mar 03, 2015 at 01:38:14PM +0200, Peter Ujfalusi wrote:
>> DMA_BIT_MASK of 64 is not valid dma address mask for OMAPs, it should be
>> set to 32.
>> The 64 was introduced by commit (in 2009):
>> a152ff24b978 ASoC: OMAP: Make DMA 64 aligned
>
> Applied, thanks.
Would it be possible to add this tags to the patch, I forgot it:
Reported-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
Thanks,
Péter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: omap-pcm: Correct dma mask
2015-03-03 14:36 ` Peter Ujfalusi
@ 2015-03-04 17:23 ` Mark Brown
0 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2015-03-04 17:23 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood, Jarkko Nikula
[-- Attachment #1.1: Type: text/plain, Size: 204 bytes --]
On Tue, Mar 03, 2015 at 04:36:34PM +0200, Peter Ujfalusi wrote:
> Would it be possible to add this tags to the patch, I forgot it:
> Reported-by: Grygorii Strashko <Grygorii.Strashko@linaro.org>
Done.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-04 17:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 11:38 [PATCH] ASoC: omap-pcm: Correct dma mask Peter Ujfalusi
2015-03-03 14:08 ` Mark Brown
2015-03-03 14:36 ` Peter Ujfalusi
2015-03-04 17:23 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.