From: Ben Greear <greearb@candelatech.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: increase station kickout threshold
Date: Tue, 03 Mar 2015 09:59:20 -0800 [thread overview]
Message-ID: <54F5F678.7030202@candelatech.com> (raw)
In-Reply-To: <1425385230-25308-2-git-send-email-rmanohar@qti.qualcomm.com>
On 03/03/2015 04:20 AM, Rajkumar Manoharan wrote:
> Since the station kickout threshold is also counting software
> reries (Default sw count in firmware is 16), increasing the threshold
> to try with already 20 data frames before kicking out the station.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/core.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 7cba781..5a0b7cb 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -50,8 +50,8 @@
>
> #define ATH10K_MAX_NUM_MGMT_PENDING 128
>
> -/* number of failed packets */
> -#define ATH10K_KICKOUT_THRESHOLD 50
> +/* number of failed packets (includes sw reties) */
> +#define ATH10K_KICKOUT_THRESHOLD (20 * 16)
Maybe add comment about '20 packets with 16 retries each', so that users know what
number is what?
Thanks,
Ben
>
> /*
> * Use insanely high numbers to make sure that the firmware implementation
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>,
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] ath10k: increase station kickout threshold
Date: Tue, 03 Mar 2015 09:59:20 -0800 [thread overview]
Message-ID: <54F5F678.7030202@candelatech.com> (raw)
In-Reply-To: <1425385230-25308-2-git-send-email-rmanohar@qti.qualcomm.com>
On 03/03/2015 04:20 AM, Rajkumar Manoharan wrote:
> Since the station kickout threshold is also counting software
> reries (Default sw count in firmware is 16), increasing the threshold
> to try with already 20 data frames before kicking out the station.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/core.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 7cba781..5a0b7cb 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -50,8 +50,8 @@
>
> #define ATH10K_MAX_NUM_MGMT_PENDING 128
>
> -/* number of failed packets */
> -#define ATH10K_KICKOUT_THRESHOLD 50
> +/* number of failed packets (includes sw reties) */
> +#define ATH10K_KICKOUT_THRESHOLD (20 * 16)
Maybe add comment about '20 packets with 16 retries each', so that users know what
number is what?
Thanks,
Ben
>
> /*
> * Use insanely high numbers to make sure that the firmware implementation
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2015-03-03 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:20 [PATCH 1/2] ath10k: fix rts profile for second rate series Rajkumar Manoharan
2015-03-03 12:20 ` Rajkumar Manoharan
2015-03-03 12:20 ` [PATCH 2/2] ath10k: increase station kickout threshold Rajkumar Manoharan
2015-03-03 12:20 ` Rajkumar Manoharan
2015-03-03 17:59 ` Ben Greear [this message]
2015-03-03 17:59 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F5F678.7030202@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.