* [PATCH 1/2] ath10k: fix rts profile for second rate series
@ 2015-03-03 12:20 ` Rajkumar Manoharan
0 siblings, 0 replies; 6+ messages in thread
From: Rajkumar Manoharan @ 2015-03-03 12:20 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
By default rts protection is enabled in firmware for the second
rateset. Currently ath10k selects RTS profile (only for software
retries), when legacy stations are associated or asked by mac80211.
On congested environment, when AP is running in HT/VHT mode and
there are no legacy clients associated, this will impact the
robustness. Also enabling RTS protection only for second rateset will
not impact performance on clear environment. Fix that.
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 84a243e..37141b3 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -798,12 +798,14 @@ static int ath10k_recalc_rtscts_prot(struct ath10k_vif *arvif)
vdev_param = ar->wmi.vdev_param->enable_rtscts;
- if (arvif->use_cts_prot || arvif->num_legacy_stations > 0)
- rts_cts |= SM(WMI_RTSCTS_ENABLED, WMI_RTSCTS_SET);
+ rts_cts |= SM(WMI_RTSCTS_ENABLED, WMI_RTSCTS_SET);
if (arvif->num_legacy_stations > 0)
rts_cts |= SM(WMI_RTSCTS_ACROSS_SW_RETRIES,
WMI_RTSCTS_PROFILE);
+ else
+ rts_cts |= SM(WMI_RTSCTS_FOR_SECOND_RATESERIES,
+ WMI_RTSCTS_PROFILE);
return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param,
rts_cts);
--
2.3.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 1/2] ath10k: fix rts profile for second rate series
@ 2015-03-03 12:20 ` Rajkumar Manoharan
0 siblings, 0 replies; 6+ messages in thread
From: Rajkumar Manoharan @ 2015-03-03 12:20 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
By default rts protection is enabled in firmware for the second
rateset. Currently ath10k selects RTS profile (only for software
retries), when legacy stations are associated or asked by mac80211.
On congested environment, when AP is running in HT/VHT mode and
there are no legacy clients associated, this will impact the
robustness. Also enabling RTS protection only for second rateset will
not impact performance on clear environment. Fix that.
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/mac.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 84a243e..37141b3 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -798,12 +798,14 @@ static int ath10k_recalc_rtscts_prot(struct ath10k_vif *arvif)
vdev_param = ar->wmi.vdev_param->enable_rtscts;
- if (arvif->use_cts_prot || arvif->num_legacy_stations > 0)
- rts_cts |= SM(WMI_RTSCTS_ENABLED, WMI_RTSCTS_SET);
+ rts_cts |= SM(WMI_RTSCTS_ENABLED, WMI_RTSCTS_SET);
if (arvif->num_legacy_stations > 0)
rts_cts |= SM(WMI_RTSCTS_ACROSS_SW_RETRIES,
WMI_RTSCTS_PROFILE);
+ else
+ rts_cts |= SM(WMI_RTSCTS_FOR_SECOND_RATESERIES,
+ WMI_RTSCTS_PROFILE);
return ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param,
rts_cts);
--
2.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ath10k: increase station kickout threshold
2015-03-03 12:20 ` Rajkumar Manoharan
@ 2015-03-03 12:20 ` Rajkumar Manoharan
-1 siblings, 0 replies; 6+ messages in thread
From: Rajkumar Manoharan @ 2015-03-03 12:20 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
Since the station kickout threshold is also counting software
reries (Default sw count in firmware is 16), increasing the threshold
to try with already 20 data frames before kicking out the station.
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 7cba781..5a0b7cb 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -50,8 +50,8 @@
#define ATH10K_MAX_NUM_MGMT_PENDING 128
-/* number of failed packets */
-#define ATH10K_KICKOUT_THRESHOLD 50
+/* number of failed packets (includes sw reties) */
+#define ATH10K_KICKOUT_THRESHOLD (20 * 16)
/*
* Use insanely high numbers to make sure that the firmware implementation
--
2.3.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] ath10k: increase station kickout threshold
@ 2015-03-03 12:20 ` Rajkumar Manoharan
0 siblings, 0 replies; 6+ messages in thread
From: Rajkumar Manoharan @ 2015-03-03 12:20 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Rajkumar Manoharan
Since the station kickout threshold is also counting software
reries (Default sw count in firmware is 16), increasing the threshold
to try with already 20 data frames before kicking out the station.
Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
---
drivers/net/wireless/ath/ath10k/core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 7cba781..5a0b7cb 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -50,8 +50,8 @@
#define ATH10K_MAX_NUM_MGMT_PENDING 128
-/* number of failed packets */
-#define ATH10K_KICKOUT_THRESHOLD 50
+/* number of failed packets (includes sw reties) */
+#define ATH10K_KICKOUT_THRESHOLD (20 * 16)
/*
* Use insanely high numbers to make sure that the firmware implementation
--
2.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ath10k: increase station kickout threshold
2015-03-03 12:20 ` Rajkumar Manoharan
@ 2015-03-03 17:59 ` Ben Greear
-1 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2015-03-03 17:59 UTC (permalink / raw)
To: Rajkumar Manoharan, ath10k; +Cc: linux-wireless
On 03/03/2015 04:20 AM, Rajkumar Manoharan wrote:
> Since the station kickout threshold is also counting software
> reries (Default sw count in firmware is 16), increasing the threshold
> to try with already 20 data frames before kicking out the station.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/core.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 7cba781..5a0b7cb 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -50,8 +50,8 @@
>
> #define ATH10K_MAX_NUM_MGMT_PENDING 128
>
> -/* number of failed packets */
> -#define ATH10K_KICKOUT_THRESHOLD 50
> +/* number of failed packets (includes sw reties) */
> +#define ATH10K_KICKOUT_THRESHOLD (20 * 16)
Maybe add comment about '20 packets with 16 retries each', so that users know what
number is what?
Thanks,
Ben
>
> /*
> * Use insanely high numbers to make sure that the firmware implementation
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] ath10k: increase station kickout threshold
@ 2015-03-03 17:59 ` Ben Greear
0 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2015-03-03 17:59 UTC (permalink / raw)
To: Rajkumar Manoharan, ath10k; +Cc: linux-wireless
On 03/03/2015 04:20 AM, Rajkumar Manoharan wrote:
> Since the station kickout threshold is also counting software
> reries (Default sw count in firmware is 16), increasing the threshold
> to try with already 20 data frames before kicking out the station.
>
> Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/core.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
> index 7cba781..5a0b7cb 100644
> --- a/drivers/net/wireless/ath/ath10k/core.h
> +++ b/drivers/net/wireless/ath/ath10k/core.h
> @@ -50,8 +50,8 @@
>
> #define ATH10K_MAX_NUM_MGMT_PENDING 128
>
> -/* number of failed packets */
> -#define ATH10K_KICKOUT_THRESHOLD 50
> +/* number of failed packets (includes sw reties) */
> +#define ATH10K_KICKOUT_THRESHOLD (20 * 16)
Maybe add comment about '20 packets with 16 retries each', so that users know what
number is what?
Thanks,
Ben
>
> /*
> * Use insanely high numbers to make sure that the firmware implementation
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-03 17:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-03 12:20 [PATCH 1/2] ath10k: fix rts profile for second rate series Rajkumar Manoharan
2015-03-03 12:20 ` Rajkumar Manoharan
2015-03-03 12:20 ` [PATCH 2/2] ath10k: increase station kickout threshold Rajkumar Manoharan
2015-03-03 12:20 ` Rajkumar Manoharan
2015-03-03 17:59 ` Ben Greear
2015-03-03 17:59 ` Ben Greear
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.