[review-request] 7191 Version2 format shaid on all layers page

[review-request] 7191 Version2 format shaid on all layers page

[Lerner, Dave]

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layers_commitfield_7191

7191 - If field looks like a commit SHAID(hex and 40 digits), truncate field as button label, and show full SHAID when button depressed.

Dave Lerner

Re: [review-request] 7191 Version2 format shaid on all layers page

[Barros Pena, Belen]

On 03/03/2015 22:56, "Lerner, Dave" <dave.lerner@windriver.com> wrote:

>http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layer
>s_commitfield_7191
>
>7191 - If field looks like a commit SHAID(hex and 40 digits), truncate
>field as button label, and show full SHAID when button depressed.

This seems to be working for me.

Thanks!

Belén

>
>Dave Lerner
>

Re: [review-request] 7191 Version2 format shaid on all layers page

[Michael Wood]

Hi Dave,

Only one thing, we have renamed the branch column to "reference" because 
the database confusingly splits up the vcs reference into, branch, 
commit, upstream branch etc etc

We have abstracted trying to work out which to display via the function 
"get_vcs_reference"

So if you switch
+ {% if o.branch|is_shaid %}
to
+ {% if o.get_vcs_reference|is_shaid %}

and you can then also remove the check to see if which kind of reference 
to display

+ {% else %}
+ {{o.up_branch.name}}

It's a bit confusing so if you'd like me just to push a patch on top 
then you can squash it into yours.

Michael


On 04/03/15 12:26, Barros Pena, Belen wrote:
> On 03/03/2015 22:56, "Lerner, Dave" <dave.lerner@windriver.com> wrote:
>
>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=lerner/layer
>> s_commitfield_7191
>>
>> 7191 - If field looks like a commit SHAID(hex and 40 digits), truncate
>> field as button label, and show full SHAID when button depressed.
> This seems to be working for me.
>
> Thanks!
>
> Belén
>
>> Dave Lerner
>>