GstVolume with dizzy is not working when changing to a value inferior to 1

GstVolume with dizzy is not working when changing to a value inferior to 1

[scerveau]

Dear all,

I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The volume 
element is not working properly.
Whith this pipeline:

gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink

The sound level is equal to 0 instead of half of the standard volume. If 
i put volume=1 this is working properly.
Affter investigation i understood that it is related to this line

gstvolume.c:251 self->current_volume = volume; in volume_update_volume

If i put any log just after this line, the behaviour is coming back to 
normal. If i compile with -00 its also working fine.

CFLAGS += " -O0"

That's my fix for now ;)

Please advise on how to fix this issue because i dont know if its 
related to the compiler (4.9.1) or to gstreamer.

Best regards.

Stéphane.

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[scerveau]

It looks that -O1 is not working either

On 03/03/2015 11:13 AM, scerveau wrote:
> Dear all,
>
> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The 
> volume element is not working properly.
> Whith this pipeline:
>
> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>
> The sound level is equal to 0 instead of half of the standard volume. 
> If i put volume=1 this is working properly.
> Affter investigation i understood that it is related to this line
>
> gstvolume.c:251 self->current_volume = volume; in volume_update_volume
>
> If i put any log just after this line, the behaviour is coming back to 
> normal. If i compile with -00 its also working fine.
>
> CFLAGS += " -O0"
>
> That's my fix for now ;)
>
> Please advise on how to fix this issue because i dont know if its 
> related to the compiler (4.9.1) or to gstreamer.
>
> Best regards.
>
> Stéphane.

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[Otavio Salvador]

Hello Stephane,

On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
> Dear all,
>
> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The volume
> element is not working properly.
> Whith this pipeline:
>
> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>
> The sound level is equal to 0 instead of half of the standard volume. If i
> put volume=1 this is working properly.
> Affter investigation i understood that it is related to this line
>
> gstvolume.c:251 self->current_volume = volume; in volume_update_volume
>
> If i put any log just after this line, the behaviour is coming back to
> normal. If i compile with -00 its also working fine.
>
> CFLAGS += " -O0"
>
> That's my fix for now ;)
>
> Please advise on how to fix this issue because i dont know if its related to
> the compiler (4.9.1) or to gstreamer.

Added Khem in Cc. Khem how we can gather info to see what's going on?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[Carlos Rafael Giani]

On 03/03/2015 01:20 PM, Otavio Salvador wrote:
> Hello Stephane,
>
> On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
>> Dear all,
>>
>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The volume
>> element is not working properly.
>> Whith this pipeline:
>>
>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>>
>> The sound level is equal to 0 instead of half of the standard volume. If i
>> put volume=1 this is working properly.
>> Affter investigation i understood that it is related to this line
>>
>> gstvolume.c:251 self->current_volume = volume; in volume_update_volume
>>
>> If i put any log just after this line, the behaviour is coming back to
>> normal. If i compile with -00 its also working fine.
>>
>> CFLAGS += " -O0"
>>
>> That's my fix for now ;)
>>
>> Please advise on how to fix this issue because i dont know if its related to
>> the compiler (4.9.1) or to gstreamer.
> Added Khem in Cc. Khem how we can gather info to see what's going on?
>

I saw this before. It is a strange error. I did a hexdump of the input 
and output samples to see what's going on. Input samples are nonzero, as 
expected. Output samples however, are all nullbytes. Sample rate, number 
of channels, sample format are all irrelevant - it occurs with them all.

This could be a compiler bug, an error in Orc, or both, especially since 
-O0 fixes it.

Carlos

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[scerveau]

Yeah !
In -O1 i dont have the same bug, even if i put the log i dont have any 
sound on output...
Only -O0 works for me. So i'm wondering if I should put -O0 for all of 
the gstreamer recipes...


On 03/03/2015 02:09 PM, Carlos Rafael Giani wrote:
> On 03/03/2015 01:20 PM, Otavio Salvador wrote:
>> Hello Stephane,
>>
>> On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
>>> Dear all,
>>>
>>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The volume
>>> element is not working properly.
>>> Whith this pipeline:
>>>
>>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>>>
>>> The sound level is equal to 0 instead of half of the standard 
>>> volume. If i
>>> put volume=1 this is working properly.
>>> Affter investigation i understood that it is related to this line
>>>
>>> gstvolume.c:251 self->current_volume = volume; in volume_update_volume
>>>
>>> If i put any log just after this line, the behaviour is coming back to
>>> normal. If i compile with -00 its also working fine.
>>>
>>> CFLAGS += " -O0"
>>>
>>> That's my fix for now ;)
>>>
>>> Please advise on how to fix this issue because i dont know if its 
>>> related to
>>> the compiler (4.9.1) or to gstreamer.
>> Added Khem in Cc. Khem how we can gather info to see what's going on?
>>
>
> I saw this before. It is a strange error. I did a hexdump of the input 
> and output samples to see what's going on. Input samples are nonzero, 
> as expected. Output samples however, are all nullbytes. Sample rate, 
> number of channels, sample format are all irrelevant - it occurs with 
> them all.
>
> This could be a compiler bug, an error in Orc, or both, especially 
> since -O0 fixes it.
>
> Carlos

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[scerveau]

Dear all,

I had a try on rpi2 and i'm facing the same issue.
The sound is not working when we change the volume value to less than 1.0
Looks like a compiler issue in gcc-4.9 on arm7 ?
My fix for now is disabling gstreamer1.0-plugins-base optimization byt 
putting CFLAGS to -O0

Best regards.

Stéphane

On 03/03/2015 02:09 PM, Carlos Rafael Giani wrote:
> On 03/03/2015 01:20 PM, Otavio Salvador wrote:
>> Hello Stephane,
>>
>> On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
>>> Dear all,
>>>
>>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The volume
>>> element is not working properly.
>>> Whith this pipeline:
>>>
>>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>>>
>>> The sound level is equal to 0 instead of half of the standard 
>>> volume. If i
>>> put volume=1 this is working properly.
>>> Affter investigation i understood that it is related to this line
>>>
>>> gstvolume.c:251 self->current_volume = volume; in volume_update_volume
>>>
>>> If i put any log just after this line, the behaviour is coming back to
>>> normal. If i compile with -00 its also working fine.
>>>
>>> CFLAGS += " -O0"
>>>
>>> That's my fix for now ;)
>>>
>>> Please advise on how to fix this issue because i dont know if its 
>>> related to
>>> the compiler (4.9.1) or to gstreamer.
>> Added Khem in Cc. Khem how we can gather info to see what's going on?
>>
>
> I saw this before. It is a strange error. I did a hexdump of the input 
> and output samples to see what's going on. Input samples are nonzero, 
> as expected. Output samples however, are all nullbytes. Sample rate, 
> number of channels, sample format are all irrelevant - it occurs with 
> them all.
>
> This could be a compiler bug, an error in Orc, or both, especially 
> since -O0 fixes it.
>
> Carlos

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[Carlos Rafael Giani]

Yes, indeed. -O2 with gcc 4.9 seems to break Orc.

Please mention this in the GStreamer mailing list.

Or, better yet, in their bugzilla: 
https://bugzilla.gnome.org/page.cgi?id=browse.html&product=GStreamer
The bugreport should go to "gst-plugins-base". Or perhaps also to "orc".

On 03/05/2015 10:54 AM, scerveau wrote:
> Dear all,
>
> I had a try on rpi2 and i'm facing the same issue.
> The sound is not working when we change the volume value to less than 1.0
> Looks like a compiler issue in gcc-4.9 on arm7 ?
> My fix for now is disabling gstreamer1.0-plugins-base optimization byt 
> putting CFLAGS to -O0
>
> Best regards.
>
> Stéphane
>
> On 03/03/2015 02:09 PM, Carlos Rafael Giani wrote:
>> On 03/03/2015 01:20 PM, Otavio Salvador wrote:
>>> Hello Stephane,
>>>
>>> On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
>>>> Dear all,
>>>>
>>>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The 
>>>> volume
>>>> element is not working properly.
>>>> Whith this pipeline:
>>>>
>>>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>>>>
>>>> The sound level is equal to 0 instead of half of the standard 
>>>> volume. If i
>>>> put volume=1 this is working properly.
>>>> Affter investigation i understood that it is related to this line
>>>>
>>>> gstvolume.c:251 self->current_volume = volume; in volume_update_volume
>>>>
>>>> If i put any log just after this line, the behaviour is coming back to
>>>> normal. If i compile with -00 its also working fine.
>>>>
>>>> CFLAGS += " -O0"
>>>>
>>>> That's my fix for now ;)
>>>>
>>>> Please advise on how to fix this issue because i dont know if its 
>>>> related to
>>>> the compiler (4.9.1) or to gstreamer.
>>> Added Khem in Cc. Khem how we can gather info to see what's going on?
>>>
>>
>> I saw this before. It is a strange error. I did a hexdump of the 
>> input and output samples to see what's going on. Input samples are 
>> nonzero, as expected. Output samples however, are all nullbytes. 
>> Sample rate, number of channels, sample format are all irrelevant - 
>> it occurs with them all.
>>
>> This could be a compiler bug, an error in Orc, or both, especially 
>> since -O0 fixes it.
>>
>> Carlos
>

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[scerveau]

Dear all,

Here is the bug tracking URL:

https://bugzilla.gnome.org/show_bug.cgi?id=745667

Best regards.

Stéphane

On 03/05/2015 11:53 AM, Carlos Rafael Giani wrote:
> Yes, indeed. -O2 with gcc 4.9 seems to break Orc.
>
> Please mention this in the GStreamer mailing list.
>
> Or, better yet, in their bugzilla: 
> https://bugzilla.gnome.org/page.cgi?id=browse.html&product=GStreamer
> The bugreport should go to "gst-plugins-base". Or perhaps also to "orc".
>
> On 03/05/2015 10:54 AM, scerveau wrote:
>> Dear all,
>>
>> I had a try on rpi2 and i'm facing the same issue.
>> The sound is not working when we change the volume value to less than 
>> 1.0
>> Looks like a compiler issue in gcc-4.9 on arm7 ?
>> My fix for now is disabling gstreamer1.0-plugins-base optimization 
>> byt putting CFLAGS to -O0
>>
>> Best regards.
>>
>> Stéphane
>>
>> On 03/03/2015 02:09 PM, Carlos Rafael Giani wrote:
>>> On 03/03/2015 01:20 PM, Otavio Salvador wrote:
>>>> Hello Stephane,
>>>>
>>>> On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
>>>>> Dear all,
>>>>>
>>>>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The 
>>>>> volume
>>>>> element is not working properly.
>>>>> Whith this pipeline:
>>>>>
>>>>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>>>>>
>>>>> The sound level is equal to 0 instead of half of the standard 
>>>>> volume. If i
>>>>> put volume=1 this is working properly.
>>>>> Affter investigation i understood that it is related to this line
>>>>>
>>>>> gstvolume.c:251 self->current_volume = volume; in 
>>>>> volume_update_volume
>>>>>
>>>>> If i put any log just after this line, the behaviour is coming 
>>>>> back to
>>>>> normal. If i compile with -00 its also working fine.
>>>>>
>>>>> CFLAGS += " -O0"
>>>>>
>>>>> That's my fix for now ;)
>>>>>
>>>>> Please advise on how to fix this issue because i dont know if its 
>>>>> related to
>>>>> the compiler (4.9.1) or to gstreamer.
>>>> Added Khem in Cc. Khem how we can gather info to see what's going on?
>>>>
>>>
>>> I saw this before. It is a strange error. I did a hexdump of the 
>>> input and output samples to see what's going on. Input samples are 
>>> nonzero, as expected. Output samples however, are all nullbytes. 
>>> Sample rate, number of channels, sample format are all irrelevant - 
>>> it occurs with them all.
>>>
>>> This could be a compiler bug, an error in Orc, or both, especially 
>>> since -O0 fixes it.
>>>
>>> Carlos
>>
>

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[scerveau]

[-- Attachment #1: Type: text/plain, Size: 2826 bytes --]

Dear all,

Here is the patch who can be merged in meta-freescale concerning 
gstvolume.c in gstreamer1.0-plugins-base
I guess this patch should be merged in poky and not in meta-freescale 
seen that the bug is also on raspberry pi 2 by example.

A bug entry has been submitted to gcc bug tracker system:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65325

Best regards.

Stéphane



On 03/05/2015 11:53 AM, Carlos Rafael Giani wrote:
> Yes, indeed. -O2 with gcc 4.9 seems to break Orc.
>
> Please mention this in the GStreamer mailing list.
>
> Or, better yet, in their bugzilla: 
> https://bugzilla.gnome.org/page.cgi?id=browse.html&product=GStreamer
> The bugreport should go to "gst-plugins-base". Or perhaps also to "orc".
>
> On 03/05/2015 10:54 AM, scerveau wrote:
>> Dear all,
>>
>> I had a try on rpi2 and i'm facing the same issue.
>> The sound is not working when we change the volume value to less than 
>> 1.0
>> Looks like a compiler issue in gcc-4.9 on arm7 ?
>> My fix for now is disabling gstreamer1.0-plugins-base optimization 
>> byt putting CFLAGS to -O0
>>
>> Best regards.
>>
>> Stéphane
>>
>> On 03/03/2015 02:09 PM, Carlos Rafael Giani wrote:
>>> On 03/03/2015 01:20 PM, Otavio Salvador wrote:
>>>> Hello Stephane,
>>>>
>>>> On Tue, Mar 3, 2015 at 7:13 AM, scerveau <scerveau@gmail.com> wrote:
>>>>> Dear all,
>>>>>
>>>>> I'm facing an issue with dizzy on imx6q and gstreamer 1.4.1. The 
>>>>> volume
>>>>> element is not working properly.
>>>>> Whith this pipeline:
>>>>>
>>>>> gst-launch-1.0 audiotestsrc ! volume volume=0.5 ! alsasink
>>>>>
>>>>> The sound level is equal to 0 instead of half of the standard 
>>>>> volume. If i
>>>>> put volume=1 this is working properly.
>>>>> Affter investigation i understood that it is related to this line
>>>>>
>>>>> gstvolume.c:251 self->current_volume = volume; in 
>>>>> volume_update_volume
>>>>>
>>>>> If i put any log just after this line, the behaviour is coming 
>>>>> back to
>>>>> normal. If i compile with -00 its also working fine.
>>>>>
>>>>> CFLAGS += " -O0"
>>>>>
>>>>> That's my fix for now ;)
>>>>>
>>>>> Please advise on how to fix this issue because i dont know if its 
>>>>> related to
>>>>> the compiler (4.9.1) or to gstreamer.
>>>> Added Khem in Cc. Khem how we can gather info to see what's going on?
>>>>
>>>
>>> I saw this before. It is a strange error. I did a hexdump of the 
>>> input and output samples to see what's going on. Input samples are 
>>> nonzero, as expected. Output samples however, are all nullbytes. 
>>> Sample rate, number of channels, sample format are all irrelevant - 
>>> it occurs with them all.
>>>
>>> This could be a compiler bug, an error in Orc, or both, especially 
>>> since -O0 fixes it.
>>>
>>> Carlos
>>
>


[-- Attachment #2: volume_explicitely_cast_integers_to_double.patch --]
[-- Type: text/x-patch, Size: 1017 bytes --]

diff --git a/gst/volume/gstvolume.c b/gst/volume/gstvolume.c
index 0f5b362..94d03a3 100644
--- a/gst/volume/gstvolume.c
+++ b/gst/volume/gstvolume.c
@@ -250,10 +250,14 @@ volume_update_volume (GstVolume * self, const GstAudioInfo * info,
     self->current_mute = FALSE;
     self->current_volume = volume;
 
-    self->current_vol_i8 = volume * VOLUME_UNITY_INT8;
-    self->current_vol_i16 = volume * VOLUME_UNITY_INT16;
-    self->current_vol_i24 = volume * VOLUME_UNITY_INT24;
-    self->current_vol_i32 = volume * VOLUME_UNITY_INT32;
+    self->current_vol_i8 =
+        (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT8);
+    self->current_vol_i16 =
+        (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT16);
+    self->current_vol_i24 =
+        (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT24);
+    self->current_vol_i32 =
+        (gint) ((gdouble) volume * (gdouble) VOLUME_UNITY_INT32);
 
     passthrough = (self->current_vol_i16 == VOLUME_UNITY_INT16);
   }

Re: GstVolume with dizzy is not working when changing to a value inferior to 1

[Otavio Salvador]

On Thu, Mar 5, 2015 at 10:34 AM, scerveau <scerveau@gmail.com> wrote:
> Dear all,
>
> Here is the patch who can be merged in meta-freescale concerning gstvolume.c
> in gstreamer1.0-plugins-base
> I guess this patch should be merged in poky and not in meta-freescale seen
> that the bug is also on raspberry pi 2 by example.
>
> A bug entry has been submitted to gcc bug tracker system:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65325

Yes; this should be done in OE-Core so it fixes the problem in the
base. We shouldn't handle this in the BSP.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750