From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC
Date: Thu, 05 Mar 2015 15:08:26 +0100 [thread overview]
Message-ID: <54F8635A.9020808@monstr.eu> (raw)
In-Reply-To: <20150305150322.19e378d9@free-electrons.com>
Hi Thomas,
On 03/05/2015 03:03 PM, Thomas Petazzoni wrote:
> Dear Michal Simek,
>
> On Thu, 5 Mar 2015 14:53:34 +0100, Michal Simek wrote:
>
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>> + interrupts = <0 143 4>,
>> + <0 144 4>,
>> + <0 145 4>,
>> + <0 146 4>;
>
> Any reason not to use
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/interrupt-controller/irq.h>
>
> in order to write the more descriptive:
>
> interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
>
> And ditto for all other interrupts properties?
I tend to not to use them because it is just hassle when I want
to move DTSes to different project.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150305/6483e80f/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Michal Simek <michal.simek@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robherring2@gmail.com>,
devicetree@vger.kernel.org, "Zach Pfeffer" <zachp@xilinx.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Mark Brown" <broonie@linaro.org>,
"Will Deacon" <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
"Robert Richter" <rrichter@cavium.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Kumar Gala" <galak@codeaurora.org>,
"Eddie Huang" <eddie.huang@mediatek.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC
Date: Thu, 05 Mar 2015 15:08:26 +0100 [thread overview]
Message-ID: <54F8635A.9020808@monstr.eu> (raw)
In-Reply-To: <20150305150322.19e378d9@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
Hi Thomas,
On 03/05/2015 03:03 PM, Thomas Petazzoni wrote:
> Dear Michal Simek,
>
> On Thu, 5 Mar 2015 14:53:34 +0100, Michal Simek wrote:
>
>> + pmu {
>> + compatible = "arm,armv8-pmuv3";
>> + interrupts = <0 143 4>,
>> + <0 144 4>,
>> + <0 145 4>,
>> + <0 146 4>;
>
> Any reason not to use
>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/interrupt-controller/irq.h>
>
> in order to write the more descriptive:
>
> interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
>
> And ditto for all other interrupts properties?
I tend to not to use them because it is just hassle when I want
to move DTSes to different project.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-03-05 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 13:53 [PATCH v2] ARM64: Add new Xilinx ZynqMP SoC Michal Simek
2015-03-05 13:53 ` Michal Simek
2015-03-05 14:03 ` Thomas Petazzoni
2015-03-05 14:03 ` Thomas Petazzoni
2015-03-05 14:08 ` Michal Simek [this message]
2015-03-05 14:08 ` Michal Simek
2015-03-05 14:05 ` Marc Zyngier
2015-03-05 14:05 ` Marc Zyngier
2015-03-05 14:05 ` Marc Zyngier
2015-03-05 14:27 ` Michal Simek
2015-03-05 14:27 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F8635A.9020808@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.