* [PATCH] test_x86_emulate: fix inline assembly in blowfish code
@ 2015-03-06 11:30 Jan Beulich
2015-03-06 11:46 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2015-03-06 11:30 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser, Euan Harris
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't
optimize debug builds; add macro debugging information") results in the
file scope inline assembly no longer being emitted to the .text section
without explicitly switching to it, which causes the blowfish test to
signal SEGV.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/tests/x86_emulator/blowfish.c
+++ b/tools/tests/x86_emulator/blowfish.c
@@ -21,7 +21,8 @@ Foundation, Inc., 59 Temple Place, Suite
uint64_t blowfish_test(uint64_t input);
asm (
- ".globl _start\n"
+ "\t.text\n"
+ "\t.globl _start\n"
"_start:\n"
#if defined(__i386__)
"push %edx; push %eax; "
[-- Attachment #2: x86emul-test-blowfish-text.patch --]
[-- Type: text/plain, Size: 751 bytes --]
test_x86_emulate: fix inline assembly in blowfish code
With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't
optimize debug builds; add macro debugging information") results in the
file scope inline assembly no longer being emitted to the .text section
without explicitly switching to it, which causes the blowfish test to
signal SEGV.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/tools/tests/x86_emulator/blowfish.c
+++ b/tools/tests/x86_emulator/blowfish.c
@@ -21,7 +21,8 @@ Foundation, Inc., 59 Temple Place, Suite
uint64_t blowfish_test(uint64_t input);
asm (
- ".globl _start\n"
+ "\t.text\n"
+ "\t.globl _start\n"
"_start:\n"
#if defined(__i386__)
"push %edx; push %eax; "
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] test_x86_emulate: fix inline assembly in blowfish code
2015-03-06 11:30 [PATCH] test_x86_emulate: fix inline assembly in blowfish code Jan Beulich
@ 2015-03-06 11:46 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2015-03-06 11:46 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Keir Fraser, Euan Harris
On 06/03/2015 11:30, Jan Beulich wrote:
> With certain gcc versions, commit 1166ecf781 ("tools/Rules.mk: Don't
> optimize debug builds; add macro debugging information") results in the
> file scope inline assembly no longer being emitted to the .text section
> without explicitly switching to it, which causes the blowfish test to
> signal SEGV.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/tools/tests/x86_emulator/blowfish.c
> +++ b/tools/tests/x86_emulator/blowfish.c
> @@ -21,7 +21,8 @@ Foundation, Inc., 59 Temple Place, Suite
> uint64_t blowfish_test(uint64_t input);
>
> asm (
> - ".globl _start\n"
> + "\t.text\n"
> + "\t.globl _start\n"
> "_start:\n"
> #if defined(__i386__)
> "push %edx; push %eax; "
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-06 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-06 11:30 [PATCH] test_x86_emulate: fix inline assembly in blowfish code Jan Beulich
2015-03-06 11:46 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.