All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>,
	mmarek-AlSwsSmVLrQ@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL@public.gmane.org,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles
Date: Mon, 09 Mar 2015 08:28:56 -0600	[thread overview]
Message-ID: <54FDAE28.6050801@osg.samsung.com> (raw)
In-Reply-To: <1425464362-28876-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>

On 03/04/2015 03:19 AM, Michael Ellerman wrote:
> The makefiles under tools/testing/selftests are not real kbuild
> makefiles, they are regular stand alone makefiles. As such they *do*
> want all the standard implicit rules and variables defined.
> 
> So before calling those makefiles, filter -rR out of MAKEFLAGS.
> 
> Without this not all the selftests are built correctly when called via
> the top-level Makefile.
> 
> Signed-off-by: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>

Hi Michal,

Could you please take this patch in your tree.

Acked-by: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Michael Ellerman <mpe@ellerman.id.au>, mmarek@suse.cz
Cc: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk,
	linux-api@vger.kernel.org
Subject: Re: [PATCH] kbuild: Don't pass -rR to selftest makefiles
Date: Mon, 09 Mar 2015 08:28:56 -0600	[thread overview]
Message-ID: <54FDAE28.6050801@osg.samsung.com> (raw)
In-Reply-To: <1425464362-28876-1-git-send-email-mpe@ellerman.id.au>

On 03/04/2015 03:19 AM, Michael Ellerman wrote:
> The makefiles under tools/testing/selftests are not real kbuild
> makefiles, they are regular stand alone makefiles. As such they *do*
> want all the standard implicit rules and variables defined.
> 
> So before calling those makefiles, filter -rR out of MAKEFLAGS.
> 
> Without this not all the selftests are built correctly when called via
> the top-level Makefile.
> 
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

Hi Michal,

Could you please take this patch in your tree.

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

  parent reply	other threads:[~2015-03-09 14:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 10:19 [PATCH] kbuild: Don't pass -rR to selftest makefiles Michael Ellerman
2015-03-04 10:19 ` Michael Ellerman
     [not found] ` <1425464362-28876-1-git-send-email-mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-03-09 14:28   ` Shuah Khan [this message]
2015-03-09 14:28     ` Shuah Khan
     [not found]     ` <54FDAE28.6050801-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-03-09 22:49       ` Shuah Khan
2015-03-09 22:49         ` Shuah Khan
     [not found]         ` <54FE2377.9040709-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-03-10 23:36           ` Michael Ellerman
2015-03-10 23:36             ` Michael Ellerman
2015-03-10 23:39             ` Shuah Khan
     [not found]               ` <54FF809F.7020205-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-03-10 23:49                 ` Michael Ellerman
2015-03-10 23:49                   ` Michael Ellerman
     [not found]                   ` <1426031386.20917.4.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-03-11  0:35                     ` Shuah Khan
2015-03-11  0:35                       ` Shuah Khan
     [not found]                       ` <54FF8DC4.6000900-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-03-11  0:46                         ` Michael Ellerman
2015-03-11  0:46                           ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54FDAE28.6050801@osg.samsung.com \
    --to=shuahkh-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
    --cc=davej-rdkfGonbjUTCLXcRTR1eJlpr/1R2p/CL@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mmarek-AlSwsSmVLrQ@public.gmane.org \
    --cc=mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.