From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developer <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH] block/qapi: Fix Sparse warning
Date: Tue, 10 Mar 2015 09:06:47 +0300 [thread overview]
Message-ID: <54FE89F7.1050108@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425766581-18250-1-git-send-email-sw@weilnetz.de>
08.03.2015 01:16, Stefan Weil wrote:
> Sparse reports this warning:
>
> block/qapi.c:417:47: warning:
> too long initializer-string for array of char(no space for nul char)
>
> Replacing the string by an array of characters fixes this warning.
> - static const char suffixes[NB_SUFFIXES] = "KMGT";
> + static const char suffixes[NB_SUFFIXES] = {'K', 'M', 'G', 'T'};
The latter is a bit uglier to my taste but oh well, damn warnings! :)
Applied to -trivial, thanks!
/mjt
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
QEMU Developer <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block/qapi: Fix Sparse warning
Date: Tue, 10 Mar 2015 09:06:47 +0300 [thread overview]
Message-ID: <54FE89F7.1050108@msgid.tls.msk.ru> (raw)
In-Reply-To: <1425766581-18250-1-git-send-email-sw@weilnetz.de>
08.03.2015 01:16, Stefan Weil wrote:
> Sparse reports this warning:
>
> block/qapi.c:417:47: warning:
> too long initializer-string for array of char(no space for nul char)
>
> Replacing the string by an array of characters fixes this warning.
> - static const char suffixes[NB_SUFFIXES] = "KMGT";
> + static const char suffixes[NB_SUFFIXES] = {'K', 'M', 'G', 'T'};
The latter is a bit uglier to my taste but oh well, damn warnings! :)
Applied to -trivial, thanks!
/mjt
next prev parent reply other threads:[~2015-03-10 6:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-07 22:16 [Qemu-trivial] [PATCH] block/qapi: Fix Sparse warning Stefan Weil
2015-03-07 22:16 ` [Qemu-devel] " Stefan Weil
2015-03-10 6:06 ` Michael Tokarev [this message]
2015-03-10 6:06 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FE89F7.1050108@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.