* [Qemu-trivial] [PATCH] cris: remove unused cris_cond15 declarations
@ 2015-03-10 5:40 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-03-10 5:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Edgar E . Iglesias, Michael Tokarev, Stefan Weil
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
disas/cris.c | 11 -----------
target-cris/opcode-cris.h | 10 ----------
2 files changed, 21 deletions(-)
diff --git a/disas/cris.c b/disas/cris.c
index 9dfb4e3..0fc7e54 100644
--- a/disas/cris.c
+++ b/disas/cris.c
@@ -1214,17 +1214,6 @@ cris_cc_strings[] =
"wf"
};
-/* Different names and semantics for condition 1111 (0xf). */
-const struct cris_cond15 cris_cond15s[] =
-{
- /* FIXME: In what version did condition "ext" disappear? */
- {"ext", cris_ver_v0_3},
- {"wf", cris_ver_v10},
- {"sb", cris_ver_v32p},
- {NULL, 0}
-};
-
-
/*
* Local variables:
* eval: (c-set-style "gnu")
diff --git a/target-cris/opcode-cris.h b/target-cris/opcode-cris.h
index 779d4aa..e7ebb98 100644
--- a/target-cris/opcode-cris.h
+++ b/target-cris/opcode-cris.h
@@ -108,16 +108,6 @@ struct cris_support_reg
};
extern const struct cris_support_reg cris_support_regs[];
-struct cris_cond15
-{
- /* The name of the condition. */
- const char *const name;
-
- /* What CPU version this condition name applies to. */
- enum cris_insn_version_usage applicable_version;
-};
-extern const struct cris_cond15 cris_conds15[];
-
/* Opcode-dependent constants. */
#define AUTOINCR_BIT (0x04)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] cris: remove unused cris_cond15 declarations
@ 2015-03-10 5:40 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-03-10 5:40 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Edgar E . Iglesias, Michael Tokarev, Stefan Weil
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
disas/cris.c | 11 -----------
target-cris/opcode-cris.h | 10 ----------
2 files changed, 21 deletions(-)
diff --git a/disas/cris.c b/disas/cris.c
index 9dfb4e3..0fc7e54 100644
--- a/disas/cris.c
+++ b/disas/cris.c
@@ -1214,17 +1214,6 @@ cris_cc_strings[] =
"wf"
};
-/* Different names and semantics for condition 1111 (0xf). */
-const struct cris_cond15 cris_cond15s[] =
-{
- /* FIXME: In what version did condition "ext" disappear? */
- {"ext", cris_ver_v0_3},
- {"wf", cris_ver_v10},
- {"sb", cris_ver_v32p},
- {NULL, 0}
-};
-
-
/*
* Local variables:
* eval: (c-set-style "gnu")
diff --git a/target-cris/opcode-cris.h b/target-cris/opcode-cris.h
index 779d4aa..e7ebb98 100644
--- a/target-cris/opcode-cris.h
+++ b/target-cris/opcode-cris.h
@@ -108,16 +108,6 @@ struct cris_support_reg
};
extern const struct cris_support_reg cris_support_regs[];
-struct cris_cond15
-{
- /* The name of the condition. */
- const char *const name;
-
- /* What CPU version this condition name applies to. */
- enum cris_insn_version_usage applicable_version;
-};
-extern const struct cris_cond15 cris_conds15[];
-
/* Opcode-dependent constants. */
#define AUTOINCR_BIT (0x04)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] cris: remove unused cris_cond15 declarations
2015-03-10 5:40 ` [Qemu-devel] " Michael Tokarev
@ 2015-03-10 7:12 ` Stefan Weil
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2015-03-10 7:12 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial, Edgar E . Iglesias
Am 10.03.2015 um 06:40 schrieb Michael Tokarev:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> disas/cris.c | 11 -----------
> target-cris/opcode-cris.h | 10 ----------
> 2 files changed, 21 deletions(-)
>
> diff --git a/disas/cris.c b/disas/cris.c
> index 9dfb4e3..0fc7e54 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -1214,17 +1214,6 @@ cris_cc_strings[] =
> "wf"
> };
>
> -/* Different names and semantics for condition 1111 (0xf). */
> -const struct cris_cond15 cris_cond15s[] =
> -{
> - /* FIXME: In what version did condition "ext" disappear? */
> - {"ext", cris_ver_v0_3},
> - {"wf", cris_ver_v10},
> - {"sb", cris_ver_v32p},
> - {NULL, 0}
> -};
> -
> -
> /*
> * Local variables:
> * eval: (c-set-style "gnu")
> diff --git a/target-cris/opcode-cris.h b/target-cris/opcode-cris.h
> index 779d4aa..e7ebb98 100644
> --- a/target-cris/opcode-cris.h
> +++ b/target-cris/opcode-cris.h
> @@ -108,16 +108,6 @@ struct cris_support_reg
> };
> extern const struct cris_support_reg cris_support_regs[];
>
> -struct cris_cond15
> -{
> - /* The name of the condition. */
> - const char *const name;
> -
> - /* What CPU version this condition name applies to. */
> - enum cris_insn_version_usage applicable_version;
> -};
> -extern const struct cris_cond15 cris_conds15[];
> -
> /* Opcode-dependent constants. */
> #define AUTOINCR_BIT (0x04)
Reviewed-by: Stefan Weil <sw@weilnetz.de>
There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
want to add that to your patch, too (keep my review then).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cris: remove unused cris_cond15 declarations
@ 2015-03-10 7:12 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2015-03-10 7:12 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel; +Cc: qemu-trivial, Edgar E . Iglesias
Am 10.03.2015 um 06:40 schrieb Michael Tokarev:
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> disas/cris.c | 11 -----------
> target-cris/opcode-cris.h | 10 ----------
> 2 files changed, 21 deletions(-)
>
> diff --git a/disas/cris.c b/disas/cris.c
> index 9dfb4e3..0fc7e54 100644
> --- a/disas/cris.c
> +++ b/disas/cris.c
> @@ -1214,17 +1214,6 @@ cris_cc_strings[] =
> "wf"
> };
>
> -/* Different names and semantics for condition 1111 (0xf). */
> -const struct cris_cond15 cris_cond15s[] =
> -{
> - /* FIXME: In what version did condition "ext" disappear? */
> - {"ext", cris_ver_v0_3},
> - {"wf", cris_ver_v10},
> - {"sb", cris_ver_v32p},
> - {NULL, 0}
> -};
> -
> -
> /*
> * Local variables:
> * eval: (c-set-style "gnu")
> diff --git a/target-cris/opcode-cris.h b/target-cris/opcode-cris.h
> index 779d4aa..e7ebb98 100644
> --- a/target-cris/opcode-cris.h
> +++ b/target-cris/opcode-cris.h
> @@ -108,16 +108,6 @@ struct cris_support_reg
> };
> extern const struct cris_support_reg cris_support_regs[];
>
> -struct cris_cond15
> -{
> - /* The name of the condition. */
> - const char *const name;
> -
> - /* What CPU version this condition name applies to. */
> - enum cris_insn_version_usage applicable_version;
> -};
> -extern const struct cris_cond15 cris_conds15[];
> -
> /* Opcode-dependent constants. */
> #define AUTOINCR_BIT (0x04)
Reviewed-by: Stefan Weil <sw@weilnetz.de>
There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
want to add that to your patch, too (keep my review then).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] cris: remove unused cris_cond15 declarations
2015-03-10 7:12 ` [Qemu-devel] " Stefan Weil
@ 2015-03-10 7:18 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-03-10 7:18 UTC (permalink / raw)
To: Stefan Weil, qemu-devel; +Cc: qemu-trivial, Edgar E . Iglesias
10.03.2015 10:12, Stefan Weil wrote:
[]
> There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
> want to add that to your patch, too (keep my review then).
Oh yeah, I overlooked it.
However maybe we should keep this somehow (maybe in a better comment
in this cris_cc_strings[] place?). I'll leave this to Edgar.
Meanwhile I updated the patch adding removal of this variable reference
from a comment in cris_cc_strings[] definition.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] cris: remove unused cris_cond15 declarations
@ 2015-03-10 7:18 ` Michael Tokarev
0 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-03-10 7:18 UTC (permalink / raw)
To: Stefan Weil, qemu-devel; +Cc: qemu-trivial, Edgar E . Iglesias
10.03.2015 10:12, Stefan Weil wrote:
[]
> There remains a comment in disas/cris.c referring to cris_conds15. Maybe you
> want to add that to your patch, too (keep my review then).
Oh yeah, I overlooked it.
However maybe we should keep this somehow (maybe in a better comment
in this cris_cc_strings[] place?). I'll leave this to Edgar.
Meanwhile I updated the patch adding removal of this variable reference
from a comment in cris_cc_strings[] definition.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-10 7:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-10 5:40 [Qemu-trivial] [PATCH] cris: remove unused cris_cond15 declarations Michael Tokarev
2015-03-10 5:40 ` [Qemu-devel] " Michael Tokarev
2015-03-10 7:12 ` [Qemu-trivial] " Stefan Weil
2015-03-10 7:12 ` [Qemu-devel] " Stefan Weil
2015-03-10 7:18 ` [Qemu-trivial] " Michael Tokarev
2015-03-10 7:18 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.