From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Subject: Re: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods
Date: Tue, 10 Mar 2015 09:34:23 +0100 [thread overview]
Message-ID: <54FEAC8F.1040206@atmel.com> (raw)
In-Reply-To: <CACRpkdazTt+_9m-iWEee2gJy4MQ+QNo3Rb2JY9hVSSXK2-dJRw@mail.gmail.com>
Le 09/03/2015 17:14, Linus Walleij a écrit :
> On Sun, Feb 8, 2015 at 7:23 PM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
>
>> The gpiochip_lock_as_irq call can fail and return an error, while the
>> irq_startup is not expected to fail (returns an unsigned int which is not
>> checked by irq core code).
>>
>> irq_request/release_resources functions have been created to address this
>> problem.
>>
>> Move gpiochip_lock/unlock_as_irq calls into
>> irq_request/release_resources functions to prevent using a gpio as an irq
>> if the gpiochip_lock_as_irq call failed.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Patch applied with all the ACKs.
Hi Linus,
As suggested earlier, do you think it can be scheduled for the 4.0-rc
phase as a "fix"?
Bye,
> Happy new year J-C!
>
> Yours,
> Linus Walleij
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods
Date: Tue, 10 Mar 2015 09:34:23 +0100 [thread overview]
Message-ID: <54FEAC8F.1040206@atmel.com> (raw)
In-Reply-To: <CACRpkdazTt+_9m-iWEee2gJy4MQ+QNo3Rb2JY9hVSSXK2-dJRw@mail.gmail.com>
Le 09/03/2015 17:14, Linus Walleij a ?crit :
> On Sun, Feb 8, 2015 at 7:23 PM, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
>
>> The gpiochip_lock_as_irq call can fail and return an error, while the
>> irq_startup is not expected to fail (returns an unsigned int which is not
>> checked by irq core code).
>>
>> irq_request/release_resources functions have been created to address this
>> problem.
>>
>> Move gpiochip_lock/unlock_as_irq calls into
>> irq_request/release_resources functions to prevent using a gpio as an irq
>> if the gpiochip_lock_as_irq call failed.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Patch applied with all the ACKs.
Hi Linus,
As suggested earlier, do you think it can be scheduled for the 4.0-rc
phase as a "fix"?
Bye,
> Happy new year J-C!
>
> Yours,
> Linus Walleij
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-03-10 8:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 18:23 [PATCH] pinctrl: at91: move lock/unlock_as_irq calls into request/release resources methods Boris Brezillon
2015-02-08 18:23 ` Boris Brezillon
2015-02-09 14:50 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-09 14:50 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-09 14:50 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20 7:50 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20 7:50 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-20 7:50 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-26 13:12 ` Boris Brezillon
2015-02-26 13:12 ` Boris Brezillon
2015-02-26 13:12 ` Boris Brezillon
2015-02-18 10:41 ` Ludovic Desroches
2015-02-18 10:41 ` Ludovic Desroches
2015-02-18 10:41 ` Ludovic Desroches
2015-02-26 13:32 ` Nicolas Ferre
2015-02-26 13:32 ` Nicolas Ferre
2015-02-26 13:32 ` Nicolas Ferre
2015-02-26 13:59 ` Jean-Christophe PLAGNIOL-VILLARD
2015-02-26 13:59 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-04 21:30 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-04 21:30 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-04 21:30 ` Jean-Christophe PLAGNIOL-VILLARD
2015-03-09 16:14 ` Linus Walleij
2015-03-09 16:14 ` Linus Walleij
2015-03-10 8:34 ` Nicolas Ferre [this message]
2015-03-10 8:34 ` Nicolas Ferre
2015-03-18 1:06 ` Linus Walleij
2015-03-18 1:06 ` Linus Walleij
2015-03-18 1:06 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FEAC8F.1040206@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=jjhiblot@traphandler.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.