Re: [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd

[Paolo Bonzini <pbonzini@redhat.com>]

On 11/03/2015 15:13, Michael S. Tsirkin wrote:
> The anonymous struct only has a single field now, drop the wrapper
> structure.
> 
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  include/hw/virtio/virtio-scsi.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index e3f27a6..f93b57d 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -134,9 +134,7 @@ typedef struct VirtIOSCSIReq {
>          VirtIOSCSIEvent       event;
>      } resp;
>      union {
> -        struct {
> -            VirtIOSCSICmdReq  cmd;
> -        } QEMU_PACKED;
> +        VirtIOSCSICmdReq      cmd;
>          VirtIOSCSICtrlTMFReq  tmf;
>          VirtIOSCSICtrlANReq   an;
>      } req;
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>