* [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd
@ 2015-03-11 14:13 Michael S. Tsirkin
2015-03-11 14:14 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2015-03-11 14:13 UTC (permalink / raw)
To: qemu-devel; +Cc: Cornelia Huck, Paolo Bonzini, Ming Lei, Fam Zheng
The anonymous struct only has a single field now, drop the wrapper
structure.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/virtio/virtio-scsi.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
index e3f27a6..f93b57d 100644
--- a/include/hw/virtio/virtio-scsi.h
+++ b/include/hw/virtio/virtio-scsi.h
@@ -134,9 +134,7 @@ typedef struct VirtIOSCSIReq {
VirtIOSCSIEvent event;
} resp;
union {
- struct {
- VirtIOSCSICmdReq cmd;
- } QEMU_PACKED;
+ VirtIOSCSICmdReq cmd;
VirtIOSCSICtrlTMFReq tmf;
VirtIOSCSICtrlANReq an;
} req;
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd
2015-03-11 14:13 [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd Michael S. Tsirkin
@ 2015-03-11 14:14 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2015-03-11 14:14 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: Cornelia Huck, Ming Lei, Fam Zheng
On 11/03/2015 15:13, Michael S. Tsirkin wrote:
> The anonymous struct only has a single field now, drop the wrapper
> structure.
>
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/virtio/virtio-scsi.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virtio/virtio-scsi.h
> index e3f27a6..f93b57d 100644
> --- a/include/hw/virtio/virtio-scsi.h
> +++ b/include/hw/virtio/virtio-scsi.h
> @@ -134,9 +134,7 @@ typedef struct VirtIOSCSIReq {
> VirtIOSCSIEvent event;
> } resp;
> union {
> - struct {
> - VirtIOSCSICmdReq cmd;
> - } QEMU_PACKED;
> + VirtIOSCSICmdReq cmd;
> VirtIOSCSICtrlTMFReq tmf;
> VirtIOSCSICtrlANReq an;
> } req;
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-11 14:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-11 14:13 [Qemu-devel] [PATCH] virtio-scsi: remove empty wrapper for cmd Michael S. Tsirkin
2015-03-11 14:14 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.