All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Konovalov <andrey.konovalov@linaro.org>
To: linux-arm-kernel@lists.infradead.org, Kukjin Kim <kgene@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org,
	"linaro-kernel@lists.linaro.org" <linaro-kernel@lists.linaro.org>
Subject: [PATCH] ARM: Exynos: Fix build error with thumb2
Date: Mon, 16 Mar 2015 20:38:43 +0300	[thread overview]
Message-ID: <55071523.7060309@linaro.org> (raw)

Add non-global symbols to avoid build failure in thumb2 mode.

Exact the same issue and the fix as in [1]; just the variables are different.

[1] http://lists.linaro.org/pipermail/linaro-kernel/2014-June/015227.html

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
---
  arch/arm/mach-exynos/sleep.S | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/sleep.S b/arch/arm/mach-exynos/sleep.S
index 31d2583..73f7fde 100644
--- a/arch/arm/mach-exynos/sleep.S
+++ b/arch/arm/mach-exynos/sleep.S
@@ -69,9 +69,9 @@ ENTRY(exynos_cpu_resume_ns)
  	cmp	r0, r1
  	bne	skip_cp15

-	adr	r0, cp15_save_power
+	adr	r0, .Lcp15_save_power
  	ldr	r1, [r0]
-	adr	r0, cp15_save_diag
+	adr	r0, .Lcp15_save_diag
  	ldr	r2, [r0]
  	mov	r0, #SMC_CMD_C15RESUME
  	dsb
@@ -118,9 +118,11 @@ skip_l2x0:
  skip_cp15:
  	b	cpu_resume
  ENDPROC(exynos_cpu_resume_ns)
+.Lcp15_save_diag:
  	.globl cp15_save_diag
  cp15_save_diag:
  	.long	0	@ cp15 diagnostic
+.Lcp15_save_power:
  	.globl cp15_save_power
  cp15_save_power:
  	.long	0	@ cp15 power control
-- 
1.9.1

WARNING: multiple messages have this Message-ID (diff)
From: andrey.konovalov@linaro.org (Andrey Konovalov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Exynos: Fix build error with thumb2
Date: Mon, 16 Mar 2015 20:38:43 +0300	[thread overview]
Message-ID: <55071523.7060309@linaro.org> (raw)

Add non-global symbols to avoid build failure in thumb2 mode.

Exact the same issue and the fix as in [1]; just the variables are different.

[1] http://lists.linaro.org/pipermail/linaro-kernel/2014-June/015227.html

Signed-off-by: Andrey Konovalov <andrey.konovalov@linaro.org>
---
  arch/arm/mach-exynos/sleep.S | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/sleep.S b/arch/arm/mach-exynos/sleep.S
index 31d2583..73f7fde 100644
--- a/arch/arm/mach-exynos/sleep.S
+++ b/arch/arm/mach-exynos/sleep.S
@@ -69,9 +69,9 @@ ENTRY(exynos_cpu_resume_ns)
  	cmp	r0, r1
  	bne	skip_cp15

-	adr	r0, cp15_save_power
+	adr	r0, .Lcp15_save_power
  	ldr	r1, [r0]
-	adr	r0, cp15_save_diag
+	adr	r0, .Lcp15_save_diag
  	ldr	r2, [r0]
  	mov	r0, #SMC_CMD_C15RESUME
  	dsb
@@ -118,9 +118,11 @@ skip_l2x0:
  skip_cp15:
  	b	cpu_resume
  ENDPROC(exynos_cpu_resume_ns)
+.Lcp15_save_diag:
  	.globl cp15_save_diag
  cp15_save_diag:
  	.long	0	@ cp15 diagnostic
+.Lcp15_save_power:
  	.globl cp15_save_power
  cp15_save_power:
  	.long	0	@ cp15 power control
-- 
1.9.1

             reply	other threads:[~2015-03-16 17:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 17:38 Andrey Konovalov [this message]
2015-03-16 17:38 ` [PATCH] ARM: Exynos: Fix build error with thumb2 Andrey Konovalov
  -- strict thread matches above, loose matches on Subject: below --
2014-05-26 15:53 [PATCH] ARM: Exynos : " Santosh Shukla
2014-05-26 15:53 ` Santosh Shukla
2014-05-28 14:03 ` Santosh Shukla
2014-05-28 14:03   ` Santosh Shukla
2014-06-02 10:10 ` Dave Martin
2014-06-02 10:10   ` Dave Martin
2014-06-04  8:07   ` Santosh Shukla
2014-06-04  8:07     ` Santosh Shukla
2014-06-11 15:13     ` Kukjin Kim
2014-06-11 15:13       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55071523.7060309@linaro.org \
    --to=andrey.konovalov@linaro.org \
    --cc=kgene@kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.