From: Kukjin Kim <kgene.kim@samsung.com>
To: Santosh Shukla <santosh.shukla@linaro.org>
Cc: Dave Martin <Dave.Martin@arm.com>,
Kukjin Kim <kgene.kim@samsung.com>, Arnd Bergmann <arnd@arndb.de>,
linux@arm.linux.org.uk, Catalin Marinas <catalin.marinas@arm.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"t.figa" <t.figa@samsung.com>,
linaro-kernel <linaro-kernel@lists.linaro.org>,
Thomas Abraham <thomas.abraham@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: Exynos : Fix build error with thumb2
Date: Thu, 12 Jun 2014 00:13:53 +0900 [thread overview]
Message-ID: <53987231.6080200@samsung.com> (raw)
In-Reply-To: <CA+iXiiO8ED9rdyxXh9ooDhb9OcBRH52acbqA7cgGX9kvgYaCXg@mail.gmail.com>
On 06/04/14 17:07, Santosh Shukla wrote:
> On 2 June 2014 15:40, Dave Martin<Dave.Martin@arm.com> wrote:
>> On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote:
>>> From: santosh shukla<santosh.shukla@linaro.org>
>>>
>>> Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode.
>>>
>>> IIUC, arm assembler fail to load value of "global" variable
>>> l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like
>>> .Ll2x0_regs_phys solves the build break issue.
>>>
>>> arch/arm/mach-exynos/sleep.S: Assembler messages:
>>> arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address
>>> calculation (value = 0x00000004)
>>>
>>> fix inspired from [1]
>>>
>>> [1] https://lkml.org/lkml/2010/3/31/235
>>>
>>> Signed-off-by: santosh shukla<santosh.shukla@linaro.org>
>>
>> Reviewed-by: Dave Martin<Dave.Martin@arm.com>
>>
>
> Thanks.
>
> Hi Kukjin, if this patch ok with you then can you pick it up.
>
Sure, I've applied this into fixes for 3.16.
Thanks,
Kukjin
>> The binutils folks insist that this is not a bug in gas. (I disagreed, but
>> it's a grey area.) This is the established pattern for working round this
>> issue -- looks fine to me.
>>
>> Cheers
>> ---Dave
WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Exynos : Fix build error with thumb2
Date: Thu, 12 Jun 2014 00:13:53 +0900 [thread overview]
Message-ID: <53987231.6080200@samsung.com> (raw)
In-Reply-To: <CA+iXiiO8ED9rdyxXh9ooDhb9OcBRH52acbqA7cgGX9kvgYaCXg@mail.gmail.com>
On 06/04/14 17:07, Santosh Shukla wrote:
> On 2 June 2014 15:40, Dave Martin<Dave.Martin@arm.com> wrote:
>> On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote:
>>> From: santosh shukla<santosh.shukla@linaro.org>
>>>
>>> Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode.
>>>
>>> IIUC, arm assembler fail to load value of "global" variable
>>> l2xo_regs_phys for thum2 mode and wrapping it in non-global symbol like
>>> .Ll2x0_regs_phys solves the build break issue.
>>>
>>> arch/arm/mach-exynos/sleep.S: Assembler messages:
>>> arch/arm/mach-exynos/sleep.S:57: Error: invalid immediate for address
>>> calculation (value = 0x00000004)
>>>
>>> fix inspired from [1]
>>>
>>> [1] https://lkml.org/lkml/2010/3/31/235
>>>
>>> Signed-off-by: santosh shukla<santosh.shukla@linaro.org>
>>
>> Reviewed-by: Dave Martin<Dave.Martin@arm.com>
>>
>
> Thanks.
>
> Hi Kukjin, if this patch ok with you then can you pick it up.
>
Sure, I've applied this into fixes for 3.16.
Thanks,
Kukjin
>> The binutils folks insist that this is not a bug in gas. (I disagreed, but
>> it's a grey area.) This is the established pattern for working round this
>> issue -- looks fine to me.
>>
>> Cheers
>> ---Dave
next prev parent reply other threads:[~2014-06-11 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 15:53 [PATCH] ARM: Exynos : Fix build error with thumb2 Santosh Shukla
2014-05-26 15:53 ` Santosh Shukla
2014-05-28 14:03 ` Santosh Shukla
2014-05-28 14:03 ` Santosh Shukla
2014-06-02 10:10 ` Dave Martin
2014-06-02 10:10 ` Dave Martin
2014-06-04 8:07 ` Santosh Shukla
2014-06-04 8:07 ` Santosh Shukla
2014-06-11 15:13 ` Kukjin Kim [this message]
2014-06-11 15:13 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2015-03-16 17:38 [PATCH] ARM: Exynos: " Andrey Konovalov
2015-03-16 17:38 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53987231.6080200@samsung.com \
--to=kgene.kim@samsung.com \
--cc=Dave.Martin@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=santosh.shukla@linaro.org \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.