All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Joseph Hindin <jhindin@daynix.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] Revised patch for QEMU Guest Agent compilaiton
Date: Mon, 23 Mar 2015 20:43:36 +0100	[thread overview]
Message-ID: <55106CE8.3080302@weilnetz.de> (raw)
In-Reply-To: <CAJAHpUYhCjJ2viionKHDeVJX=pK22=QQjuO1DuSFRaWjQz-naA@mail.gmail.com>

Am 23.03.2015 um 20:29 schrieb Joseph Hindin:
> Hi
>
>    About a week ago I've submitted the revised patch for QEMU GA 
> Windows cross-compilation. Since then I've not got any responses. 
> Would you mind to look into the proposed patch?
>
>     Regards,
>
>        Joseph Hindin
>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg03155.html

Maybe you would have got a response if you had sent that patch to Paolo 
or me, too.
Your patch has formal issues: it should have a short subject (< 80 
characters typically)
and some description. Your patch puts all text into the subject, so this 
becomes
rather long. Please send an updated patch with "git send-email" and use 
scripts/checkpatch.pl
before you send it.

Is there any reason why you filter the -fstack-protector% the way you 
did in your patch
(and not as suggested by Paolo)?

Technically I think your patch fixes the problem.

Thanks,
Stefan




WARNING: multiple messages have this Message-ID (diff)
From: Stefan Weil <sw@weilnetz.de>
To: Joseph Hindin <jhindin@daynix.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Revised patch for QEMU Guest Agent compilaiton
Date: Mon, 23 Mar 2015 20:43:36 +0100	[thread overview]
Message-ID: <55106CE8.3080302@weilnetz.de> (raw)
In-Reply-To: <CAJAHpUYhCjJ2viionKHDeVJX=pK22=QQjuO1DuSFRaWjQz-naA@mail.gmail.com>

Am 23.03.2015 um 20:29 schrieb Joseph Hindin:
> Hi
>
>    About a week ago I've submitted the revised patch for QEMU GA 
> Windows cross-compilation. Since then I've not got any responses. 
> Would you mind to look into the proposed patch?
>
>     Regards,
>
>        Joseph Hindin
>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg03155.html

Maybe you would have got a response if you had sent that patch to Paolo 
or me, too.
Your patch has formal issues: it should have a short subject (< 80 
characters typically)
and some description. Your patch puts all text into the subject, so this 
becomes
rather long. Please send an updated patch with "git send-email" and use 
scripts/checkpatch.pl
before you send it.

Is there any reason why you filter the -fstack-protector% the way you 
did in your patch
(and not as suggested by Paolo)?

Technically I think your patch fixes the problem.

Thanks,
Stefan

       reply	other threads:[~2015-03-23 19:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAJAHpUYhCjJ2viionKHDeVJX=pK22=QQjuO1DuSFRaWjQz-naA@mail.gmail.com>
2015-03-23 19:43 ` Stefan Weil [this message]
2015-03-23 19:43   ` [Qemu-devel] Revised patch for QEMU Guest Agent compilaiton Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55106CE8.3080302@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=jhindin@daynix.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.