All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [Qemu-trivial] Revised patch for QEMU Guest Agent compilaiton
       [not found] <CAJAHpUYhCjJ2viionKHDeVJX=pK22=QQjuO1DuSFRaWjQz-naA@mail.gmail.com>
@ 2015-03-23 19:43   ` Stefan Weil
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2015-03-23 19:43 UTC (permalink / raw)
  To: Joseph Hindin; +Cc: QEMU Trivial, Paolo Bonzini, QEMU Developer

Am 23.03.2015 um 20:29 schrieb Joseph Hindin:
> Hi
>
>    About a week ago I've submitted the revised patch for QEMU GA 
> Windows cross-compilation. Since then I've not got any responses. 
> Would you mind to look into the proposed patch?
>
>     Regards,
>
>        Joseph Hindin
>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg03155.html

Maybe you would have got a response if you had sent that patch to Paolo 
or me, too.
Your patch has formal issues: it should have a short subject (< 80 
characters typically)
and some description. Your patch puts all text into the subject, so this 
becomes
rather long. Please send an updated patch with "git send-email" and use 
scripts/checkpatch.pl
before you send it.

Is there any reason why you filter the -fstack-protector% the way you 
did in your patch
(and not as suggested by Paolo)?

Technically I think your patch fixes the problem.

Thanks,
Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [Qemu-devel] Revised patch for QEMU Guest Agent compilaiton
@ 2015-03-23 19:43   ` Stefan Weil
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Weil @ 2015-03-23 19:43 UTC (permalink / raw)
  To: Joseph Hindin; +Cc: QEMU Trivial, Paolo Bonzini, Michael Roth, QEMU Developer

Am 23.03.2015 um 20:29 schrieb Joseph Hindin:
> Hi
>
>    About a week ago I've submitted the revised patch for QEMU GA 
> Windows cross-compilation. Since then I've not got any responses. 
> Would you mind to look into the proposed patch?
>
>     Regards,
>
>        Joseph Hindin
>
> http://lists.nongnu.org/archive/html/qemu-devel/2015-03/msg03155.html

Maybe you would have got a response if you had sent that patch to Paolo 
or me, too.
Your patch has formal issues: it should have a short subject (< 80 
characters typically)
and some description. Your patch puts all text into the subject, so this 
becomes
rather long. Please send an updated patch with "git send-email" and use 
scripts/checkpatch.pl
before you send it.

Is there any reason why you filter the -fstack-protector% the way you 
did in your patch
(and not as suggested by Paolo)?

Technically I think your patch fixes the problem.

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-23 19:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAJAHpUYhCjJ2viionKHDeVJX=pK22=QQjuO1DuSFRaWjQz-naA@mail.gmail.com>
2015-03-23 19:43 ` [Qemu-trivial] Revised patch for QEMU Guest Agent compilaiton Stefan Weil
2015-03-23 19:43   ` [Qemu-devel] " Stefan Weil

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.