From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Geoff Levand <geoff@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org, hbabus@us.ibm.com,
linaro-kernel@lists.linaro.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
broonie@kernel.org, david.griego@linaro.org,
kexec@lists.infradead.org, vgoyal@redhat.com
Subject: Re: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel
Date: Mon, 30 Mar 2015 12:21:31 +0900 [thread overview]
Message-ID: <5518C13B.6070201@linaro.org> (raw)
In-Reply-To: <1427408957.6526.1.camel@infradead.org>
On 03/27/2015 07:29 AM, Geoff Levand wrote:
> On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
>> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr)
>> setup_mm_for_reboot();
>>
>> cpu_soft_restart(virt_to_phys(cpu_reset),
>> - is_hyp_mode_available(), addr);
>> +#ifdef CONFIG_KEXEC
>> + !in_crash_kexec &&
>> +#endif
>
> Why not define in_crash_kexec without condition on CONFIG_KEXEC, say
> here in process.c and then avoid these preprocessor conditionals.
Well, I thought of that, but as its name suggested, the variable should
be basically part of kdump code.
Moreover, I suspect that some one might reject a whole idea of patch #3.
-Takahiro AKASHI
>> + is_hyp_mode_available(),
>> + addr);
>>
>> /* Should never get here */
>> BUG();
>
>
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel
Date: Mon, 30 Mar 2015 12:21:31 +0900 [thread overview]
Message-ID: <5518C13B.6070201@linaro.org> (raw)
In-Reply-To: <1427408957.6526.1.camel@infradead.org>
On 03/27/2015 07:29 AM, Geoff Levand wrote:
> On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
>> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr)
>> setup_mm_for_reboot();
>>
>> cpu_soft_restart(virt_to_phys(cpu_reset),
>> - is_hyp_mode_available(), addr);
>> +#ifdef CONFIG_KEXEC
>> + !in_crash_kexec &&
>> +#endif
>
> Why not define in_crash_kexec without condition on CONFIG_KEXEC, say
> here in process.c and then avoid these preprocessor conditionals.
Well, I thought of that, but as its name suggested, the variable should
be basically part of kdump code.
Moreover, I suspect that some one might reject a whole idea of patch #3.
-Takahiro AKASHI
>> + is_hyp_mode_available(),
>> + addr);
>>
>> /* Should never get here */
>> BUG();
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Geoff Levand <geoff@infradead.org>
Cc: catalin.marinas@arm.com, will.deacon@arm.com, vgoyal@redhat.com,
hbabus@us.ibm.com, broonie@kernel.org, david.griego@linaro.org,
kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel
Date: Mon, 30 Mar 2015 12:21:31 +0900 [thread overview]
Message-ID: <5518C13B.6070201@linaro.org> (raw)
In-Reply-To: <1427408957.6526.1.camel@infradead.org>
On 03/27/2015 07:29 AM, Geoff Levand wrote:
> On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
>> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr)
>> setup_mm_for_reboot();
>>
>> cpu_soft_restart(virt_to_phys(cpu_reset),
>> - is_hyp_mode_available(), addr);
>> +#ifdef CONFIG_KEXEC
>> + !in_crash_kexec &&
>> +#endif
>
> Why not define in_crash_kexec without condition on CONFIG_KEXEC, say
> here in process.c and then avoid these preprocessor conditionals.
Well, I thought of that, but as its name suggested, the variable should
be basically part of kdump code.
Moreover, I suspect that some one might reject a whole idea of patch #3.
-Takahiro AKASHI
>> + is_hyp_mode_available(),
>> + addr);
>>
>> /* Should never get here */
>> BUG();
>
>
>
next prev parent reply other threads:[~2015-03-30 3:22 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 8:28 [PATCH 0/5] arm64: add kdump support AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` [PATCH 1/5] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 18:30 ` Geoff Levand
2015-03-26 18:30 ` Geoff Levand
2015-03-26 18:30 ` Geoff Levand
2015-03-27 4:43 ` Geoff Levand
2015-03-27 4:43 ` Geoff Levand
2015-03-27 4:43 ` Geoff Levand
2015-03-30 2:35 ` AKASHI Takahiro
2015-03-30 2:35 ` AKASHI Takahiro
2015-03-30 2:35 ` AKASHI Takahiro
2015-04-09 13:09 ` Pratyush Anand
2015-04-09 13:09 ` Pratyush Anand
2015-04-09 13:09 ` Pratyush Anand
2015-04-10 5:57 ` AKASHI Takahiro
2015-04-10 5:57 ` AKASHI Takahiro
2015-04-10 5:57 ` AKASHI Takahiro
2015-04-10 6:35 ` Pratyush Anand
2015-04-10 6:35 ` Pratyush Anand
2015-04-10 6:35 ` Pratyush Anand
2015-03-26 8:28 ` [PATCH 2/5] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 22:29 ` Geoff Levand
2015-03-26 22:29 ` Geoff Levand
2015-03-26 22:29 ` Geoff Levand
2015-03-30 3:21 ` AKASHI Takahiro [this message]
2015-03-30 3:21 ` AKASHI Takahiro
2015-03-30 3:21 ` AKASHI Takahiro
2015-03-26 8:28 ` [PATCH 4/5] arm64: add kdump support AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` [PATCH 5/5] arm64: enable kdump in the arm64 defconfig AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-03-26 8:28 ` AKASHI Takahiro
2015-04-01 15:56 ` [PATCH 0/5] arm64: add kdump support Pratyush Anand
2015-04-01 15:56 ` Pratyush Anand
2015-04-01 15:56 ` Pratyush Anand
2015-04-01 23:27 ` AKASHI Takahiro
2015-04-01 23:27 ` AKASHI Takahiro
2015-04-01 23:27 ` AKASHI Takahiro
2015-04-02 4:58 ` Pratyush Anand
2015-04-02 4:58 ` Pratyush Anand
2015-04-02 4:58 ` Pratyush Anand
2015-04-02 5:37 ` AKASHI Takahiro
2015-04-02 5:37 ` AKASHI Takahiro
2015-04-02 5:37 ` AKASHI Takahiro
2015-04-02 6:01 ` Pratyush Anand
2015-04-02 6:01 ` Pratyush Anand
2015-04-02 6:01 ` Pratyush Anand
2015-04-02 7:48 ` AKASHI Takahiro
2015-04-02 7:48 ` AKASHI Takahiro
2015-04-02 7:48 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5518C13B.6070201@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david.griego@linaro.org \
--cc=geoff@infradead.org \
--cc=hbabus@us.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.