From: Michael Wood <michael.g.wood@intel.com>
To: "Reyna, David" <david.reyna@windriver.com>,
"BARROS PENA, BELEN" <belen.barros.pena@intel.com>,
"DAMIAN, ALEXANDRU" <alexandru.damian@intel.com>
Cc: "toaster@yoctoproject.org" <toaster@yoctoproject.org>
Subject: Re: [review-request] dreyna/projects_pagecount_7483
Date: Tue, 31 Mar 2015 15:10:38 +0100 [thread overview]
Message-ID: <551AAADE.8070308@intel.com> (raw)
In-Reply-To: <5E53D14CE4667A45B9A06760DE5D13D07789881F@ALA-MBA.corp.ad.wrs.com>
Looks good to me.
[These are the kind of bugs I'm hoping will go away with RFC ToasterTable!]
On 31/03/15 02:36, Reyna, David wrote:
> Hi Belén and Michael,
>
> I went ahead and grabbed (and solved) 7483 "Searching in the all projects table resets the 'show rows' menu to '10'" since it was still in the new state.
>
> dreyna/projects_pagecount_7483
>
> The "count" value for the all projects page was not fully saved in the cookies because the view class did not end with a '_save_parameters_cookies'.
>
> The intermediate cookie "_count" was there (from basetable_bottom.html) which is why it kind of worked, but that is not used when a search is issued.
>
> - David
>
next prev parent reply other threads:[~2015-03-31 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 1:36 [review-request] dreyna/projects_pagecount_7483 Reyna, David
2015-03-31 14:10 ` Michael Wood [this message]
2015-03-31 16:37 ` Barros Pena, Belen
2015-04-16 14:17 ` Damian, Alexandru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551AAADE.8070308@intel.com \
--to=michael.g.wood@intel.com \
--cc=alexandru.damian@intel.com \
--cc=belen.barros.pena@intel.com \
--cc=david.reyna@windriver.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.