[review-request] dreyna/projects_pagecount_7483

[review-request] dreyna/projects_pagecount_7483

[Reyna, David]

Hi Belén and Michael,

I went ahead and grabbed (and solved) 7483 "Searching in the all projects table resets the 'show rows' menu to '10'" since it was still in the new state.

    dreyna/projects_pagecount_7483

The "count" value for the all projects page was not fully saved in the cookies because the view class did not end with a '_save_parameters_cookies'.

The intermediate cookie "_count" was there (from basetable_bottom.html) which is why it kind of worked, but that is not used when a search is issued.

- David

Re: [review-request] dreyna/projects_pagecount_7483

[Michael Wood]

Looks good to me.

[These are the kind of bugs I'm hoping will go away with RFC ToasterTable!]

On 31/03/15 02:36, Reyna, David wrote:
> Hi Belén and Michael,
>
> I went ahead and grabbed (and solved) 7483 "Searching in the all projects table resets the 'show rows' menu to '10'" since it was still in the new state.
>
>      dreyna/projects_pagecount_7483
>
> The "count" value for the all projects page was not fully saved in the cookies because the view class did not end with a '_save_parameters_cookies'.
>
> The intermediate cookie "_count" was there (from basetable_bottom.html) which is why it kind of worked, but that is not used when a search is issued.
>
> - David
>

Re: [review-request] dreyna/projects_pagecount_7483

[Barros Pena, Belen]

On 31/03/2015 15:10, "Michael Wood" <michael.g.wood@intel.com> wrote:

>Looks good to me.
>
>[These are the kind of bugs I'm hoping will go away with RFC
>ToasterTable!]

Looks good from the outside too ;) We should probably have a chat about
that RFC tomorrow during the Toaster meeting.

Cheers

Belén

>
>On 31/03/15 02:36, Reyna, David wrote:
>> Hi Belén and Michael,
>>
>> I went ahead and grabbed (and solved) 7483 "Searching in the all
>>projects table resets the 'show rows' menu to '10'" since it was still
>>in the new state.
>>
>>      dreyna/projects_pagecount_7483
>>
>> The "count" value for the all projects page was not fully saved in the
>>cookies because the view class did not end with a
>>'_save_parameters_cookies'.
>>
>> The intermediate cookie "_count" was there (from basetable_bottom.html)
>>which is why it kind of worked, but that is not used when a search is
>>issued.
>>
>> - David
>>
>

Re: [review-request] dreyna/projects_pagecount_7483

[Damian, Alexandru]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

Taken for submission,

Agreed, we need a better implementation of the Table functionality.

Thanks,
Alex

On Tue, Mar 31, 2015 at 5:37 PM, Barros Pena, Belen <
belen.barros.pena@intel.com> wrote:

>
>
> On 31/03/2015 15:10, "Michael Wood" <michael.g.wood@intel.com> wrote:
>
> >Looks good to me.
> >
> >[These are the kind of bugs I'm hoping will go away with RFC
> >ToasterTable!]
>
> Looks good from the outside too ;) We should probably have a chat about
> that RFC tomorrow during the Toaster meeting.
>
> Cheers
>
> Belén
>
> >
> >On 31/03/15 02:36, Reyna, David wrote:
> >> Hi Belén and Michael,
> >>
> >> I went ahead and grabbed (and solved) 7483 "Searching in the all
> >>projects table resets the 'show rows' menu to '10'" since it was still
> >>in the new state.
> >>
> >>      dreyna/projects_pagecount_7483
> >>
> >> The "count" value for the all projects page was not fully saved in the
> >>cookies because the view class did not end with a
> >>'_save_parameters_cookies'.
> >>
> >> The intermediate cookie "_count" was there (from basetable_bottom.html)
> >>which is why it kind of worked, but that is not used when a search is
> >>issued.
> >>
> >> - David
> >>
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC

[-- Attachment #2: Type: text/html, Size: 2517 bytes --]