From: David Vrabel <david.vrabel@citrix.com>
To: Bob Liu <bob.liu@oracle.com>, xen-devel@lists.xenproject.org
Cc: jgross@suse.com, paul.durrant@citrix.com, wei.liu2@citrix.com,
david.vrabel@citrix.com, roger.pau@citrix.com
Subject: Re: [PATCH 2/3] blkif: enable multi-page ring supporting
Date: Wed, 8 Apr 2015 11:46:44 +0100 [thread overview]
Message-ID: <55250714.7070406@citrix.com> (raw)
In-Reply-To: <1428043501-13912-2-git-send-email-bob.liu@oracle.com>
On 03/04/15 07:45, Bob Liu wrote:
> Remove the 'DEPRECATED' and next patch will follow the protocol defined here to
> support multi-page ring.
Why are you un-deprecating this instead of using max-ring-page-order?
Are you allowing for non power of two counts? If so, the documentation
needs to be updated as well.
Also num-ring-pages is also tagged as deprecated.
Changes in blkif.h need to be made in Xen first.
David
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -303,7 +303,7 @@
> * Values: <uint32_t>
> * Default Value: 1
> * Maximum Value: MAX(max-ring-pages,(0x1 << max-ring-page-order))
> - * Notes: DEPRECATED, 2, 3
> + * Notes: 2, 3
> *
> * The size of the frontend allocated request ring buffer in units of
> * machine pages. The value must be a power of 2.
>
next prev parent reply other threads:[~2015-04-08 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 6:44 [PATCH v6 1/3] xenbus_client: Extend interface to support multi-page ring Bob Liu
2015-04-03 6:45 ` [PATCH 2/3] blkif: enable multi-page ring supporting Bob Liu
2015-04-08 10:46 ` David Vrabel [this message]
2015-04-08 14:21 ` Konrad Rzeszutek Wilk
2015-04-08 14:25 ` David Vrabel
2015-04-09 1:08 ` Bob Liu
2015-04-03 6:45 ` [PATCH v3 3/3] xen/block: add multi-page ring support Bob Liu
2015-04-08 5:23 ` [PATCH v6 1/3] xenbus_client: Extend interface to support multi-page ring Juergen Gross
2015-04-08 13:26 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55250714.7070406@citrix.com \
--to=david.vrabel@citrix.com \
--cc=bob.liu@oracle.com \
--cc=jgross@suse.com \
--cc=paul.durrant@citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.