Re: [PATCH 2/3] blkif: enable multi-page ring supporting

[David Vrabel <david.vrabel@citrix.com>]

On 08/04/15 15:21, Konrad Rzeszutek Wilk wrote:
> On Wed, Apr 08, 2015 at 11:46:44AM +0100, David Vrabel wrote:
>> On 03/04/15 07:45, Bob Liu wrote:
>>> Remove the 'DEPRECATED' and next patch will follow the protocol defined here to
>>> support multi-page ring.
>>
>> Why are you un-deprecating this instead of using max-ring-page-order?
>> Are you allowing for non power of two counts? If so, the documentation
>> needs to be updated as well.
>>
>> Also num-ring-pages is also tagged as deprecated.
>>
>> Changes in blkif.h need to be made in Xen first.
> 
> Um, this patch is against Xen tree.

With this being patch #2 in a Linux series no one else is going to
notice this is Xen patch either.

David

>>> --- a/xen/include/public/io/blkif.h
>>> +++ b/xen/include/public/io/blkif.h
>>> @@ -303,7 +303,7 @@
>>>   *      Values:         <uint32_t>
>>>   *      Default Value:  1
>>>   *      Maximum Value:  MAX(max-ring-pages,(0x1 << max-ring-page-order))
>>> - *      Notes:          DEPRECATED, 2, 3
>>> + *      Notes:          2, 3
>>>   *
>>>   *      The size of the frontend allocated request ring buffer in units of
>>>   *      machine pages.  The value must be a power of 2.
>>>
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel