Re: [PATCH 05/10] VMX: add help functions to support PML

[Kai Huang <kai.huang@linux.intel.com>]

On 04/09/2015 08:31 PM, Tim Deegan wrote:
> At 10:35 +0800 on 27 Mar (1427452549), Kai Huang wrote:
>> +void vmx_vcpu_disable_pml(struct vcpu *v)
>> +{
>> +    ASSERT(vmx_vcpu_pml_enabled(v));
>> +
> I think this function ought to call vmx_vcpu_flush_pml_buffer() before
> disabling PML.  That way we don't need to worry about losing any
> information if a guest vcpu is reset or offlined during migration.
Good point. Thanks for catching. Will do :)

Thanks,
-Kai
>
> Cheers,
>
> Tim.