From: Ezequiel Garcia <ezequiel-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
To: Pelle Nilsson
<per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org
Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional
Date: Tue, 14 Apr 2015 12:36:22 -0300 [thread overview]
Message-ID: <552D33F6.2020407@vanguardiasur.com.ar> (raw)
In-Reply-To: <1429018817-18117-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
On 04/14/2015 10:40 AM, Pelle Nilsson wrote:
> Some controller drivers have no need of this callback (spi-altera even
> causes a NULL pointer dereference because it doesn't register the callback,
> falsely assuming that it is already optional).
>
> Fixes: 30af9b558a56 ("spi/bitbang: Drop empty setup() functions")
> Signed-off-by: Pelle Nilsson <per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
Please note the merge window is open, so don't expect Mark to pick
your change soon.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Pelle Nilsson <per.nilsson@xelmo.com>, broonie@kernel.org
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
nios2-dev@lists.rocketboards.org
Subject: Re: [PATCH v2] spi: bitbang: Make setup_transfer() callback optional
Date: Tue, 14 Apr 2015 12:36:22 -0300 [thread overview]
Message-ID: <552D33F6.2020407@vanguardiasur.com.ar> (raw)
In-Reply-To: <1429018817-18117-1-git-send-email-per.nilsson@xelmo.com>
On 04/14/2015 10:40 AM, Pelle Nilsson wrote:
> Some controller drivers have no need of this callback (spi-altera even
> causes a NULL pointer dereference because it doesn't register the callback,
> falsely assuming that it is already optional).
>
> Fixes: 30af9b558a56 ("spi/bitbang: Drop empty setup() functions")
> Signed-off-by: Pelle Nilsson <per.nilsson@xelmo.com>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@vanguardiasur.com.ar>
Please note the merge window is open, so don't expect Mark to pick
your change soon.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2015-04-14 15:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 15:03 [PATCH 0/1] Fix NULL pointer dereference Pelle Nilsson
2015-04-09 15:03 ` Pelle Nilsson
[not found] ` <1428591822-24279-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 15:03 ` [PATCH 1/1] spi: altera: Add empty implementation of setup_transfer callback Pelle Nilsson
2015-04-09 15:03 ` Pelle Nilsson
[not found] ` <1428591822-24279-2-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 15:40 ` Mark Brown
2015-04-09 15:40 ` Mark Brown
[not found] ` <20150409154045.GZ6023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-04-09 15:50 ` Pelle Nilsson
2015-04-09 15:50 ` Pelle Nilsson
[not found] ` <55269FDC.8040306-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 16:10 ` Mark Brown
2015-04-09 16:10 ` Mark Brown
2015-04-13 9:45 ` Pelle Nilsson
[not found] ` <552B9045.4040709-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-13 10:08 ` [PATCH] spi: bitbang: Make setup_transfer callback optional Pelle Nilsson
2015-04-13 10:08 ` Pelle Nilsson
[not found] ` <1428919685-14190-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-14 0:22 ` [Nios2-dev] " Ezequiel Garcia
2015-04-14 0:22 ` Ezequiel Garcia
2015-04-14 13:40 ` [PATCH v2] spi: bitbang: Make setup_transfer() " Pelle Nilsson
2015-04-14 13:40 ` Pelle Nilsson
[not found] ` <1429018817-18117-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-14 15:36 ` Ezequiel Garcia [this message]
2015-04-14 15:36 ` Ezequiel Garcia
2015-04-18 11:00 ` Mark Brown
2015-04-18 11:00 ` Mark Brown
2015-04-09 15:26 ` [PATCH 0/1] Fix NULL pointer dereference Mark Brown
2015-04-09 15:26 ` Mark Brown
2015-04-09 15:54 ` [PATCH v2] spi: altera: Add empty implementation of setup_transfer callback Pelle Nilsson
2015-04-09 15:54 ` Pelle Nilsson
[not found] ` <1428594853-24640-1-git-send-email-per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org>
2015-04-09 16:23 ` Mark Brown
2015-04-09 16:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552D33F6.2020407@vanguardiasur.com.ar \
--to=ezequiel-30ulvvutt6g51wmpkgsgjgyuob5fgqpz@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nios2-dev-g9ZBwUv/Ih/yUk5EbOjzuce+I+R0W71w@public.gmane.org \
--cc=per.nilsson-5TWeZ6kPplYAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.