* [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits
@ 2015-04-10 22:44 Tariq Saeed
2015-04-16 5:42 ` Junxiao Bi
0 siblings, 1 reply; 2+ messages in thread
From: Tariq Saeed @ 2015-04-10 22:44 UTC (permalink / raw)
To: ocfs2-devel
Orabug: 19060842
In ocfs2_local_alloc_find_clear_bits(), local int numbits is used
without being initialized in an error path.
Signed-off-by: Tariq Saeed <tariq.x.saeed@oracle.com>
---
fs/ocfs2/localalloc.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
index 0440134..978a6e0 100644
--- a/fs/ocfs2/localalloc.c
+++ b/fs/ocfs2/localalloc.c
@@ -847,6 +847,7 @@ static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb,
if (!alloc->id1.bitmap1.i_total) {
bitoff = -1;
+ numfound = -1;
goto bail;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits
2015-04-10 22:44 [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits Tariq Saeed
@ 2015-04-16 5:42 ` Junxiao Bi
0 siblings, 0 replies; 2+ messages in thread
From: Junxiao Bi @ 2015-04-16 5:42 UTC (permalink / raw)
To: ocfs2-devel
Hi Tariq,
This have been fixed by upstream commit
023d4ea358494ccfeb37abfe5b0fd01b45a6051c ("ocfs2: fix possible
uninitialized variable access").
Thanks,
Junxiao.
On 04/11/2015 06:44 AM, Tariq Saeed wrote:
> Orabug: 19060842
>
> In ocfs2_local_alloc_find_clear_bits(), local int numbits is used
> without being initialized in an error path.
>
> Signed-off-by: Tariq Saeed <tariq.x.saeed@oracle.com>
> ---
> fs/ocfs2/localalloc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/fs/ocfs2/localalloc.c b/fs/ocfs2/localalloc.c
> index 0440134..978a6e0 100644
> --- a/fs/ocfs2/localalloc.c
> +++ b/fs/ocfs2/localalloc.c
> @@ -847,6 +847,7 @@ static int ocfs2_local_alloc_find_clear_bits(struct ocfs2_super *osb,
>
> if (!alloc->id1.bitmap1.i_total) {
> bitoff = -1;
> + numfound = -1;
> goto bail;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-16 5:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10 22:44 [Ocfs2-devel] [PATCH 1/1] automated tool detected uninitialized variable use in ocfs2_local_alloc_find_clear_bits Tariq Saeed
2015-04-16 5:42 ` Junxiao Bi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.