From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Huacai Chen <chenhc@lemote.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>,
<linux-mips@linux-mips.org>, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
"Kelvin Cheung" <keguang.zhang@gmail.com>
Subject: Re: [PATCH V2] MIPS: Loongson: Naming style cleanup and rework
Date: Tue, 21 Apr 2015 10:38:14 +0100 [thread overview]
Message-ID: <55361A86.9060000@imgtec.com> (raw)
In-Reply-To: <1429581635-26476-1-git-send-email-chenhc@lemote.com>
Hi,
On 04/21/2015 03:00 AM, Huacai Chen wrote:
> Currently, code of Loongson-2/3 is under loongson directory and code of
> Loongson-1 is under loongson1 directory. Besides, there are Kconfig
> options such as MACH_LOONGSON and MACH_LOONGSON1. This naming style is
> very ugly and confusing. Since Loongson-2/3 are both 64-bit general-
> purpose CPU while Loongson-1 is 32-bit SoC, we rename both file names
> and Kconfig symbols from loongson/loongson1 to loongson64/loongson32.
>
> V2: Update Kconfig description.
This ^^^^ needs to be below the '---' part of the patch because it
should not be part of the commit message. It is just a changelog for the
patch itself.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
^^^ Please add "V2:..." here instead.
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Huacai Chen <chenhc@lemote.com>, Ralf Baechle <ralf@linux-mips.org>
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Kelvin Cheung <keguang.zhang@gmail.com>
Subject: Re: [PATCH V2] MIPS: Loongson: Naming style cleanup and rework
Date: Tue, 21 Apr 2015 10:38:14 +0100 [thread overview]
Message-ID: <55361A86.9060000@imgtec.com> (raw)
Message-ID: <20150421093814.5kY4Czvlory9eTojLGf8YQHFY1h7u40pplwvZrU0GrA@z> (raw)
In-Reply-To: <1429581635-26476-1-git-send-email-chenhc@lemote.com>
Hi,
On 04/21/2015 03:00 AM, Huacai Chen wrote:
> Currently, code of Loongson-2/3 is under loongson directory and code of
> Loongson-1 is under loongson1 directory. Besides, there are Kconfig
> options such as MACH_LOONGSON and MACH_LOONGSON1. This naming style is
> very ugly and confusing. Since Loongson-2/3 are both 64-bit general-
> purpose CPU while Loongson-1 is 32-bit SoC, we rename both file names
> and Kconfig symbols from loongson/loongson1 to loongson64/loongson32.
>
> V2: Update Kconfig description.
This ^^^^ needs to be below the '---' part of the patch because it
should not be part of the commit message. It is just a changelog for the
patch itself.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
^^^ Please add "V2:..." here instead.
--
markos
next prev parent reply other threads:[~2015-04-21 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 2:00 [PATCH V2] MIPS: Loongson: Naming style cleanup and rework Huacai Chen
2015-04-21 9:38 ` Markos Chandras [this message]
2015-04-21 9:38 ` Markos Chandras
2015-04-22 0:34 ` Huacai Chen
2015-04-29 15:16 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55361A86.9060000@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=Steven.Hill@imgtec.com \
--cc=chenhc@lemote.com \
--cc=keguang.zhang@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.