From: Jennifer Herbert <Jennifer.Herbert@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tim Deegan <tim@xen.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCHv3 0/4] Use ticket locks for spinlocks
Date: Tue, 21 Apr 2015 12:24:55 +0100 [thread overview]
Message-ID: <55363387.6040900@citrix.com> (raw)
In-Reply-To: <55364119020000780007434E@mail.emea.novell.com>
On 21/04/15 11:22, Jan Beulich wrote:
> Despite both pictures saying micro-seconds at the respective axis (and
> hence the problem not being _as bad_) - did the data collection reveal
> where these IRQ disable regions are, so we could look into eliminating
> them? (ISTR there being some open coded IRQ-disable, lock, unlock,
> IRQ-restore/enable sequences, but I'm not sure whether they got
> eliminated already.) Jan
The location of the locks was not collected, (Other then if it was from
a spinlock or not) but I'm certainly considering doing this, as another
graph of duration against cumulative time, shows the majority of time
spent with interrupts disabled, is during code that keeps it disabled
for long contiguous periods, all using raw (not spinlock) Interrupt
disable. (A few occurrences, but very long when they happen) It would
certainly be interesting to know where these come from.
-jenny
next prev parent reply other threads:[~2015-04-21 11:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 10:11 [PATCHv3 0/4] Use ticket locks for spinlocks David Vrabel
2015-04-21 10:11 ` [PATCHv3 1/4] x86: provide xadd() David Vrabel
2015-04-21 10:36 ` Jan Beulich
2015-04-21 12:36 ` David Vrabel
2015-04-21 13:12 ` Jan Beulich
2015-04-21 13:15 ` David Vrabel
2015-04-21 13:20 ` Jan Beulich
2015-04-21 10:11 ` [PATCHv3 2/4] arm: " David Vrabel
2015-04-21 10:11 ` [PATCHv3 3/4] xen: use ticket locks for spin locks David Vrabel
2015-04-23 11:58 ` Jan Beulich
2015-04-28 15:56 ` David Vrabel
2015-04-28 23:15 ` Jan Beulich
2015-04-29 15:21 ` David Vrabel
2015-04-29 23:56 ` Jan Beulich
2015-04-30 10:09 ` Tim Deegan
2015-04-30 11:55 ` David Vrabel
2015-04-23 12:03 ` Tim Deegan
2015-04-23 13:43 ` David Vrabel
2015-04-23 13:45 ` Andrew Cooper
2015-04-23 14:58 ` Tim Deegan
2015-04-23 14:24 ` Tim Deegan
2015-04-23 14:51 ` Tim Deegan
2015-04-23 13:54 ` Jan Beulich
2015-04-23 14:43 ` Tim Deegan
2015-04-23 14:58 ` Jan Beulich
2015-04-29 15:36 ` David Vrabel
2015-04-29 16:56 ` Tim Deegan
2015-04-29 17:00 ` David Vrabel
2015-04-30 9:00 ` Tim Deegan
2015-04-29 23:48 ` Jan Beulich
2015-04-21 10:11 ` [PATCHv3 4/4] x86, arm: remove asm/spinlock.h from all architectures David Vrabel
2015-04-21 10:22 ` [PATCHv3 0/4] Use ticket locks for spinlocks Jan Beulich
2015-04-21 11:24 ` Jennifer Herbert [this message]
2015-04-23 12:42 ` David Vrabel
2015-04-30 15:44 ` David Vrabel
2015-05-04 7:18 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55363387.6040900@citrix.com \
--to=jennifer.herbert@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.