From: Paolo Bonzini <pbonzini@redhat.com>
To: Firo Yang <firogm@gmail.com>, gleb@kernel.org
Cc: kernel-janitors@vger.kernel.org, christoffer.dall@linaro.org,
marc.zyngier@arm.com, linux@arm.linux.org.uk,
kvm@vger.kernel.org
Subject: Re: [PATCH] ARM: KVM: Remove pointless void pointer cast
Date: Thu, 23 Apr 2015 10:40:38 +0000 [thread overview]
Message-ID: <5538CC26.3060601@redhat.com> (raw)
In-Reply-To: <1429783660-7222-1-git-send-email-firogm@gmail.com>
On 23/04/2015 12:07, Firo Yang wrote:
> No need to cast the void pointer returned by kmalloc() in
> arch/arm/kvm/mmu.c::kvm_alloc_stage2_pgd().
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> ---
> arch/arm/kvm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index 1d5accb..ce0bce4 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
> @@ -691,8 +691,8 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm)
> * work. This is not used by the hardware and we have no
> * alignment requirement for this allocation.
> */
> - pgd = (pgd_t *)kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
> - GFP_KERNEL | __GFP_ZERO);
> + pgd = kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
> + GFP_KERNEL | __GFP_ZERO);
>
> if (!pgd) {
> kvm_free_hwpgd(hwpgd);
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Firo Yang <firogm@gmail.com>, gleb@kernel.org
Cc: kernel-janitors@vger.kernel.org, christoffer.dall@linaro.org,
marc.zyngier@arm.com, linux@arm.linux.org.uk,
kvm@vger.kernel.org
Subject: Re: [PATCH] ARM: KVM: Remove pointless void pointer cast
Date: Thu, 23 Apr 2015 12:40:38 +0200 [thread overview]
Message-ID: <5538CC26.3060601@redhat.com> (raw)
In-Reply-To: <1429783660-7222-1-git-send-email-firogm@gmail.com>
On 23/04/2015 12:07, Firo Yang wrote:
> No need to cast the void pointer returned by kmalloc() in
> arch/arm/kvm/mmu.c::kvm_alloc_stage2_pgd().
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> ---
> arch/arm/kvm/mmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index 1d5accb..ce0bce4 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
> @@ -691,8 +691,8 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm)
> * work. This is not used by the hardware and we have no
> * alignment requirement for this allocation.
> */
> - pgd = (pgd_t *)kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
> - GFP_KERNEL | __GFP_ZERO);
> + pgd = kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t),
> + GFP_KERNEL | __GFP_ZERO);
>
> if (!pgd) {
> kvm_free_hwpgd(hwpgd);
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2015-04-23 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 10:07 [PATCH] ARM: KVM: Remove pointless void pointer cast Firo Yang
2015-04-23 10:07 ` Firo Yang
2015-04-23 10:40 ` Paolo Bonzini [this message]
2015-04-23 10:40 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538CC26.3060601@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=firogm@gmail.com \
--cc=gleb@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.