[PATCH] backports: fix high RC version parsing in dependency library

[PATCH] backports: fix high RC version parsing in dependency library

[Mathy Vanhoef]

This updates the dependency library to handle RC versions up to 39. For
example, coccinelle version "1.0.0" is now correctly treated as being higher
than version "1.0.0-rc24".

Signed-off-by: Mathy Vanhoef <vanhoefm@gmail.com>
---
 lib/bpreqs.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/bpreqs.py b/lib/bpreqs.py
index 6c46670..4399c6d 100644
--- a/lib/bpreqs.py
+++ b/lib/bpreqs.py
@@ -98,7 +98,7 @@ class Req:
                 if (rc == ""):
                     rc = 0
                 else:
-                    rc = int(rc) - 20
+                    rc = int(rc) - 40
                 extra = int(rc)
             else:
                 extra = int(rel_specs['EXTRAVERSION']) + 10
-- 
1.7.10.4

Re: [PATCH] backports: fix high RC version parsing in dependency library

[Arend van Spriel]

On 04/28/15 01:56, Mathy Vanhoef wrote:
> This updates the dependency library to handle RC versions up to 39. For
> example, coccinelle version "1.0.0" is now correctly treated as being higher
> than version "1.0.0-rc24".

This one is duplicate to the patch Eliad submitted [1]. Any reason for 
choosing rc 40?

Regards,
Arend

[1] http://mid.gmane.org/1430126344-1068-1-git-send-email-eliad@wizery.com

> Signed-off-by: Mathy Vanhoef<vanhoefm@gmail.com>
> ---
>   lib/bpreqs.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/bpreqs.py b/lib/bpreqs.py
> index 6c46670..4399c6d 100644
> --- a/lib/bpreqs.py
> +++ b/lib/bpreqs.py
> @@ -98,7 +98,7 @@ class Req:
>                   if (rc == ""):
>                       rc = 0
>                   else:
> -                    rc = int(rc) - 20
> +                    rc = int(rc) - 40
>                   extra = int(rc)
>               else:
>                   extra = int(rel_specs['EXTRAVERSION']) + 10

Re: [PATCH] backports: fix high RC version parsing in dependency library

[Mathy Vanhoef]

On Tue, Apr 28, 2015 at 10:27 AM, Arend van Spriel <arend@broadcom.com> wrote:
> On 04/28/15 01:56, Mathy Vanhoef wrote:
>>
>> This updates the dependency library to handle RC versions up to 39. For
>> example, coccinelle version "1.0.0" is now correctly treated as being
>> higher
>> than version "1.0.0-rc24".
>
>
> This one is duplicate to the patch Eliad submitted [1]. Any reason for
> choosing rc 40?

I missed that patched. My reasoning was that previously at least the Linux
kernel went up to rc 39 with 2.6.39. So 40 should be a good limit to support
most cases.

Kr,
Mathy

> Regards,
> Arend
>
> [1] http://mid.gmane.org/1430126344-1068-1-git-send-email-eliad@wizery.com
>
>
>> Signed-off-by: Mathy Vanhoef<vanhoefm@gmail.com>
>> ---
>>   lib/bpreqs.py |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/bpreqs.py b/lib/bpreqs.py
>> index 6c46670..4399c6d 100644
>> --- a/lib/bpreqs.py
>> +++ b/lib/bpreqs.py
>> @@ -98,7 +98,7 @@ class Req:
>>                   if (rc == ""):
>>                       rc = 0
>>                   else:
>> -                    rc = int(rc) - 20
>> +                    rc = int(rc) - 40
>>                   extra = int(rc)
>>               else:
>>                   extra = int(rel_specs['EXTRAVERSION']) + 10
>
>

Re: [PATCH] backports: fix high RC version parsing in dependency library

[Eliad Peller]

On Tue, Apr 28, 2015 at 1:26 PM, Mathy Vanhoef <vanhoefm@gmail.com> wrote:
> On Tue, Apr 28, 2015 at 10:27 AM, Arend van Spriel <arend@broadcom.com> wrote:
>> On 04/28/15 01:56, Mathy Vanhoef wrote:
>>>
>>> This updates the dependency library to handle RC versions up to 39. For
>>> example, coccinelle version "1.0.0" is now correctly treated as being
>>> higher
>>> than version "1.0.0-rc24".
>>
>>
>> This one is duplicate to the patch Eliad submitted [1]. Any reason for
>> choosing rc 40?
>
> I missed that patched. My reasoning was that previously at least the Linux
> kernel went up to rc 39 with 2.6.39. So 40 should be a good limit to support
> most cases.
>
note that 39 in this case is the "sublevel", not the "extraversion".

Eliad.

Re: [PATCH] backports: fix high RC version parsing in dependency library

[Hauke Mehrtens]

On 04/28/2015 02:25 PM, Eliad Peller wrote:
> On Tue, Apr 28, 2015 at 1:26 PM, Mathy Vanhoef <vanhoefm@gmail.com> wrote:
>> On Tue, Apr 28, 2015 at 10:27 AM, Arend van Spriel <arend@broadcom.com> wrote:
>>> On 04/28/15 01:56, Mathy Vanhoef wrote:
>>>>
>>>> This updates the dependency library to handle RC versions up to 39. For
>>>> example, coccinelle version "1.0.0" is now correctly treated as being
>>>> higher
>>>> than version "1.0.0-rc24".
>>>
>>>
>>> This one is duplicate to the patch Eliad submitted [1]. Any reason for
>>> choosing rc 40?
>>
>> I missed that patched. My reasoning was that previously at least the Linux
>> kernel went up to rc 39 with 2.6.39. So 40 should be a good limit to support
>> most cases.
>>
> note that 39 in this case is the "sublevel", not the "extraversion".
> 
> Eliad.

I will take your patch Eliad. There are so many magic numbers in this
code it probably has to get cleaned up, a warning for such a case like
we have it now would also be nice.

Hauke