From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Michael Welling <mwelling@ieee.org>
Cc: Mike Turquette <mturquette@linaro.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Jean-Francois Moine <moinejf@free.fr>,
Russell King <rmk+linux@arm.linux.org.uk>,
devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] clk: si5351: Reset PLL after rate change
Date: Thu, 30 Apr 2015 20:58:10 +0200 [thread overview]
Message-ID: <55427B42.9060902@gmail.com> (raw)
In-Reply-To: <20150430184932.GB22000@deathray>
On 30.04.2015 20:49, Michael Welling wrote:
> On Thu, Apr 30, 2015 at 07:45:54PM +0200, Sebastian Hesselbarth wrote:
>> When changing PLL rate significantly, PLLs have to be reset. Add a function
>> to perform and check for successful PLL reset.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
[...]
>> @@ -519,6 +545,9 @@ static int si5351_pll_set_rate(struct clk_hw *hw, unsigned long rate,
>> SI5351_CLK_INTEGER_MODE,
>> (hwdata->params.p2 == 0) ? SI5351_CLK_INTEGER_MODE : 0);
>>
>> + /* reset pll after rate change */
>> + si5351_pll_reset(hwdata);
>> +
>
> What is the point of having a return code if it is not being used?
Good point, I'll pass that on to the return value of .set_rate()
callback for v2.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] clk: si5351: Reset PLL after rate change
Date: Thu, 30 Apr 2015 20:58:10 +0200 [thread overview]
Message-ID: <55427B42.9060902@gmail.com> (raw)
In-Reply-To: <20150430184932.GB22000@deathray>
On 30.04.2015 20:49, Michael Welling wrote:
> On Thu, Apr 30, 2015 at 07:45:54PM +0200, Sebastian Hesselbarth wrote:
>> When changing PLL rate significantly, PLLs have to be reset. Add a function
>> to perform and check for successful PLL reset.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
[...]
>> @@ -519,6 +545,9 @@ static int si5351_pll_set_rate(struct clk_hw *hw, unsigned long rate,
>> SI5351_CLK_INTEGER_MODE,
>> (hwdata->params.p2 == 0) ? SI5351_CLK_INTEGER_MODE : 0);
>>
>> + /* reset pll after rate change */
>> + si5351_pll_reset(hwdata);
>> +
>
> What is the point of having a return code if it is not being used?
Good point, I'll pass that on to the return value of .set_rate()
callback for v2.
Sebastian
next prev parent reply other threads:[~2015-04-30 18:58 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 17:45 [PATCH 0/4] clk: si5351: Some fixes Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 1/4] clk: si5351: Mention clock-names in the binding documentation Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 2/4] ARM: dove: Add clock-names to CuBox Si5351 clk generator Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 3/4] clk: si5351: Do not pass struct clk in platform_data Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 18:20 ` Fabio Estevam
2015-04-30 18:20 ` Fabio Estevam
2015-04-30 18:30 ` Michael Welling
2015-04-30 18:30 ` Michael Welling
2015-04-30 18:44 ` Sebastian Hesselbarth
2015-04-30 18:44 ` Sebastian Hesselbarth
2015-04-30 19:16 ` Fabio Estevam
2015-04-30 19:16 ` Fabio Estevam
2015-04-30 20:46 ` Sebastian Hesselbarth
2015-04-30 20:46 ` Sebastian Hesselbarth
2015-04-30 17:45 ` [PATCH 4/4] clk: si5351: Reset PLL after rate change Sebastian Hesselbarth
2015-04-30 17:45 ` Sebastian Hesselbarth
2015-04-30 18:49 ` Michael Welling
2015-04-30 18:49 ` Michael Welling
2015-04-30 18:58 ` Sebastian Hesselbarth [this message]
2015-04-30 18:58 ` Sebastian Hesselbarth
2015-04-30 18:47 ` [PATCH 0/4] clk: si5351: Some fixes Michael Welling
2015-04-30 18:47 ` Michael Welling
2015-04-30 19:33 ` Michael Welling
2015-04-30 19:33 ` Michael Welling
2015-04-30 19:33 ` Michael Welling
2015-04-30 20:44 ` Sebastian Hesselbarth
2015-04-30 20:44 ` Sebastian Hesselbarth
2015-04-30 20:44 ` Sebastian Hesselbarth
2015-04-30 21:20 ` Michael Welling
2015-04-30 21:20 ` Michael Welling
2015-04-30 21:20 ` Michael Welling
2015-04-30 22:21 ` Sebastian Hesselbarth
2015-04-30 22:21 ` Sebastian Hesselbarth
2015-04-30 22:21 ` Sebastian Hesselbarth
2015-04-30 22:36 ` Michael Welling
2015-04-30 22:36 ` Michael Welling
2015-04-30 22:36 ` Michael Welling
2015-05-01 8:17 ` Sebastian Hesselbarth
2015-05-01 8:17 ` Sebastian Hesselbarth
2015-05-01 8:17 ` Sebastian Hesselbarth
2015-05-08 0:52 ` Michael Welling
2015-05-08 0:52 ` Michael Welling
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:14 ` Jean-Francois Moine
2015-05-01 9:30 ` Sebastian Hesselbarth
2015-05-01 9:30 ` Sebastian Hesselbarth
2015-05-02 8:53 ` Jean-Francois Moine
2015-05-02 8:55 ` Jean-Francois Moine
2015-05-02 8:55 ` Jean-Francois Moine
2015-05-02 8:55 ` Jean-Francois Moine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55427B42.9060902@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mturquette@linaro.org \
--cc=mwelling@ieee.org \
--cc=rmk+linux@arm.linux.org.uk \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.